Repository navigation
Reach public ReactCommon modules through umbrellas from Android platform headers - #58886
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123610673. |
j-piasecki
force-pushed
the
export-D123610673
branch
2 times, most recently
from
October 6, 2026 12:47
2d5bf15 to
438d33d
Compare
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Oct 7, 2026
…orm headers (react#58886) Summary: Android headers exported through prefab (`react/fabric/AndroidEventBeat.h`, `EventEmitterWrapper.h`, `FabricMountingManager.h`, `StateWrapperImpl.h`, `ComponentFactory.h`, `CoreComponentsRegistry.h`, `react/common/mapbuffer/JReadableMapBuffer.h`, and `DefaultComponentsRegistry.h`, which app `OnLoad.cpp` files include) included fine-grained headers of public ReactCommon modules. Under `RN_STRICT_API` those hit the modules' public guard in any app or library that includes them, so they now include `<React/RendererCore.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>` and `<React/MapBuffer.h>` instead. Includes of "for frameworks" headers are unchanged. The guards are inert without that flag. Changelog: [Internal] Differential Revision: D123610673
j-piasecki
force-pushed
the
export-D123610673
branch
from
October 7, 2026 07:37
438d33d to
648824d
Compare
…orm headers Summary: Android headers exported through prefab (`react/fabric/*`, `JReadableMapBuffer.h`, and `DefaultComponentsRegistry.h`, which app `OnLoad.cpp` files include) included fine-grained headers of public ReactCommon modules, which trip the modules' public guard under `RN_STRICT_API` in any app or library including them. Switch them to the module umbrellas (`<React/RendererCore.h>`, `<React/ComponentRegistry.h>`, `<React/Debug.h>`, `<React/MapBuffer.h>`). "For frameworks" includes stay direct, since umbrellas do not re-export them: `ComponentFactory.h` keeps `<react/renderer/componentregistry/ComponentDescriptorFactory.h>` for `ComponentRegistryFactory`. To keep that framework-tier header out of app code, `DefaultComponentsRegistry.h` now forward-declares `ComponentFactory` (it only takes it by pointer) and `DefaultComponentsRegistry.cpp` includes it. The guards are inert without `RN_STRICT_API`. Changelog: [Internal] Differential Revision: D123610673
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D123610673
branch
from
October 7, 2026 10:34
648824d to
fcc8a31
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android headers exported through prefab (
react/fabric/*,JReadableMapBuffer.h, andDefaultComponentsRegistry.h, which appOnLoad.cppfiles include) included fine-grained headers of public ReactCommon modules, which trip the modules' public guard underRN_STRICT_APIin any app or library including them. Switch them to the module umbrellas (<React/RendererCore.h>,<React/ComponentRegistry.h>,<React/Debug.h>,<React/MapBuffer.h>)."For frameworks" includes stay direct, since umbrellas do not re-export them:
ComponentFactory.hkeeps<react/renderer/componentregistry/ComponentDescriptorFactory.h>forComponentRegistryFactory. To keep that framework-tier header out of app code,DefaultComponentsRegistry.hnow forward-declaresComponentFactory(it only takes it by pointer) andDefaultComponentsRegistry.cppincludes it. The guards are inert withoutRN_STRICT_API.Changelog: [Internal]
Differential Revision: D123610673