Repository navigation
Keep RNTester content clear of the iOS tab bar - #58933
Closed
cipolleschi wants to merge 5 commits into
Closed
cipolleschi wants to merge 5 commits into
cipolleschi wants to merge 5 commits into
Conversation
The iOS Maestro runner ignored flow tags, so the maintainVisibleContentPosition flows tagged android-release-only also ran on iOS. Since #58900 changed the RNTester tab bar insets, flatlist-append-maintainvisible fails deterministically on iOS and blocks the iOS RNTester E2E job on every PR. Add exclude-tags support to the iOS runner (reusing the Android tag filter) and skip android-release-only flows in the iOS RNTester workflow until the inset regression is fixed.
meta-cla
Bot
added
the
CLA Signed
Drop the android-release-only skip: the failing flow needs to run so its debug output can show where Maestro taps. Write each attempt's debug output to its own folder under /tmp/MaestroLogs, which the maestro-ios action already uploads on failure.
cipolleschi
changed the title
#58900 capped the bottom content inset at 65pt for bottom tab bars, but the tab bar is 83pt tall on current iPhones. The bottom 18pt of every RNTester screen sat under the tab bar, so taps there switched tabs. flatlist-append-maintainvisible taps "Reset" at y=874 and landed on the Playground tab. Use the full bottom safe-area inset instead.
cipolleschi
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D123941583. |
cortinico
approved these changes
Oct 7, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cipolleschi merged this pull request in c65fc63. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The iOS RNTester E2E job fails on every PR.
flatlist-append-maintainvisible.ymlfails withElement not found: Id matching regex: scroll-offset-display. It started with #58900 (8d8b8f3).#58900 caps the bottom content inset at 65pt when the tab bar is along the bottom (
insets.bottom = MIN(insets.bottom, LegacyBottomInset)), but the tab bar is 83pt tall on current iPhones. The bottom 18pt of every RNTester screen sits under the tab bar. A tap there switches tabs instead of reaching the content.That's what breaks the flow. The maintainVisibleContentPosition example pins its controls to the bottom of the screen. Its last row ("Clear (empty list)" / "Reset", y=866–882 on an iPhone 17 Pro Max) straddles the tab bar's top edge (y=873). Maestro taps "Reset" at its center, (326, 874), and that lands on the Playground tab. The next lookup of
scroll-offset-displaythen fails because RNTester is on a different screen.This PR changes the
MINtoMAX, matching the top inset'sMAX(insets.top, LegacyTopInset). The bottom inset is now never smaller than the system inset, so content stays clear of the tab bar. On devices whose inset is under 65pt, it still keeps the legacy 65pt bounds that #58900 wanted.Trade-off: on devices where the tab bar is taller than 65pt (83pt on current iPhones), examples are now 18pt shorter than #58900 intended. That's the space the tab bar covers.
Changelog:
[INTERNAL] - Keep RNTester content clear of the iOS tab bar
Test Plan:
On an iPhone 17 Pro Max simulator (iOS 26.5):
main, ranmaestro test packages/rn-tester/.maestro/flatlist-append-maintainvisible.yml --debug-output <dir>(Maestro 2.6.1, same as CI). It failed afterTap on "Reset". The debug output shows the tap onReset(bounds[222,866][430,882]) and the failure screenshot shows the Playground tab.idb ui describe-all. The Clear/Reset row moved from y=866–882 to y=848–864, which is above the tab bar at y=873. On this device the system inset is 83pt, soMAX(83, 65)gives the same layout. I didn't rebuild with the finalMAXversion.yarn format-check-cpp: no violations in repository files.BEFORE-e2eFailing.mov
AFTER-e2eSucceeding.mov