refactor: use transient props for styled-components v6+#398
Open
tegaki-tegaki wants to merge 1 commit intoreact95-io:masterfrom
Open
refactor: use transient props for styled-components v6+#398tegaki-tegaki wants to merge 1 commit intoreact95-io:masterfrom
tegaki-tegaki wants to merge 1 commit intoreact95-io:masterfrom
Conversation
limehawk
added a commit
to limehawk/React95
that referenced
this pull request
Apr 16, 2026
Convert all styled-component prop names to $-prefixed transient props to prevent DOM attribute leaking in styled-components v6. This is a styled-components best practice that ensures custom props are consumed by styled-components and never forwarded to the underlying DOM element. Components updated: Anchor, AppBar, Avatar, Button, ColorInput, Counter/Digit, DatePicker, Frame, GroupBox, Handle, Hourglass, NumberInput, ProgressBar, ScrollView, Select, Separator, Slider, Tabs, TextInput, Toolbar, Tooltip, TreeView, Window, WindowHeader. Also adds forwardRef to Handle and Separator which were previously bare styled-components without ref forwarding. Closes upstream react95-io#398, closes upstream react95-io#390.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a heavily LLM assisted refactoring (might be some things missing, might be a bit odd here and there)
closes #390