Refactor SettingsBase to use primary constructor, improve cache #1147
+343
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection Refactored SettingsBase to use a C# primary constructor and updated the logic for selecting the appropriate IBlobCache. The new logic prioritizes explicitly created caches, falls back to CacheDatabase caches, and finally creates an in-memory cache if a serializer is available. Improved error handling and exception messages for missing caches.
The CI workflow now runs on pull requests targeting the main branch. Added global environment variable for productNamespacePrefix and set build configuration to Release.
glennawatson
approved these changes
Dec 4, 2025
Copilot finished reviewing on behalf of
glennawatson
December 4, 2025 22:02
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors SettingsBase to use C# 12 primary constructors and significantly improves the cache selection logic with a multi-tier fallback chain. The changes prioritize explicitly created settings caches, fall back to CacheDatabase caches when needed, and create transient in-memory caches as a last resort before throwing exceptions.
Key changes:
- Modernized
SettingsBaseto use primary constructor syntax, reducing boilerplate - Implemented comprehensive fallback logic: AkavacheBuilder.BlobCaches → CacheDatabase (UserAccount/LocalMachine/InMemory) → InMemoryBlobCache via service locator → exception
- Enhanced error messages to handle null/empty cache scenarios more gracefully
- Minor CI workflow improvements adding explicit configuration parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/Akavache.Settings/SettingsBase.cs | Refactored to use primary constructor and added multi-tier cache fallback logic with improved error handling |
| .github/workflows/ci-build.yml | Added explicit configuration: Release parameter and simplified branch trigger syntax |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 55.75% 56.44% +0.68%
==========================================
Files 35 35
Lines 3126 3141 +15
Branches 660 665 +5
==========================================
+ Hits 1743 1773 +30
+ Misses 1119 1097 -22
- Partials 264 271 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@ChrisPulman I've opened a new pull request, #1148, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
|
@ChrisPulman I've opened a new pull request, #1149, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add test coverage for SettingsBase fallback logic - Tests verify fallback to CacheDatabase.UserAccount when no explicit cache configured - Tests verify settings persistence across instances - Tests demonstrate the fallback priority logic - Some edge case tests remain challenging due to static state interference Co-authored-by: ChrisPulman <[email protected]> * Complete fallback test coverage with passing tests - All new tests pass successfully - All existing tests continue to pass (18 total) - Tests validate CacheDatabase fallback when no explicit cache configured - Tests validate settings persistence across multiple instances - Removed flaky tests that had static state interference issues Co-authored-by: ChrisPulman <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ChrisPulman <[email protected]> Co-authored-by: Chris Pulman <[email protected]>
) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ChrisPulman <[email protected]> Co-authored-by: Chris Pulman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update
What is the new behavior?
Refactored SettingsBase to use a C# primary constructor and updated the logic for selecting the appropriate IBlobCache. The new logic prioritizes explicitly created caches, falls back to CacheDatabase caches, and finally creates an in-memory cache if a serializer is available. Improved error handling and exception messages for missing caches.
What might this PR break?
Please check if the PR fulfills these requirements
Other information: