Repository navigation
Conversation
A subscriber cancelling before setRefCountMonitor/setRefConnection had marked the monitor as set (synchronously inside onSubscribe, or racing it from another thread) was not counted out of the connection. The ref-count stayed inflated and the shared upstream was never disconnected. cancel() now always records the cancellation with a CAS retry loop and decrements the count. subscribe() skips connecting only if that cancel already disposed the connection, so other subscribers still waiting to reach n get connected. Fixes #4289 Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A subscriber cancelling before
setRefCountMonitor/setRefConnectionhad marked the monitor as set (synchronously inside onSubscribe, or racing it from another thread) was not counted out of the connection. The ref-count stayed inflated and the shared upstream was never disconnected.cancel()now always records the cancellation with a CAS retry loop and decrements the count.subscribe()skips connecting only if thatcancelalready disposed the connection, so other subscribers still waiting to reachnget connected.Fixes #4289