Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 4, 2026 12:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502.
glm_spincurrently right-multiplies a rotation built around the matrix's translation. Translating to(5, 0, 0)and spinning 90 degrees about Z changes the position to(10, -5, 0).Build an origin-centered rotation instead. For an affine matrix
[A, t; 0, 1], the existing right multiplication then produces[A R, t; 0, 1], preserving translation and the pre-transform multiplication order. The shared implementation also fixesglmc_spinandglms_spin.Add five registered regressions covering translated matrices, an existing rotation with nonuniform scale, a nonunit axis, inverse and zero angles, rotation at the origin, and struct input preservation. Expected matrices are written explicitly.
Validation on the unchanged patch:
-Wconversion -Werror: 9/9.The Windows CMake MinGW generator failed before compilation in the Unicode workspace path; its build is not claimed as passing. The Linux C99 suite retains pre-existing anonymous-struct warnings. MSVC, macOS, ARM/NEON, WebAssembly, the full SIMD build matrix, and upstream CI have not been run.