fix(redisotel): change metric types from UpDownCounter to Counter #3650
+84
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue #3612: Change db.client.connections.timeouts, waits, hits, and misses from Int64ObservableUpDownCounter to Int64ObservableCounter to comply with OpenTelemetry conventions. According to OpenTelemetry semantic conventions, these metrics represent cumulative counts that only increase, so they should be Counters, not UpDownCounters. This allows proper use of rate() functions in Prometheus and other metric exporters. Changed metrics: - db.client.connections.timeouts - db.client.connections.waits - db.client.connections.hits - db.client.connections.misses This is a breaking change for users relying on the previous metric type, but it aligns with OpenTelemetry best practices and enables proper metric aggregation and rate calculations.
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
added 2 commits
December 13, 2025 16:59
Fix issue #3612: Change db.client.connections.timeouts, waits, hits, and misses from Int64ObservableUpDownCounter to Int64ObservableCounter to comply with OpenTelemetry conventions. According to OpenTelemetry semantic conventions, these metrics represent cumulative counts that only increase, so they should be Counters, not UpDownCounters. This allows proper use of rate() functions in Prometheus and other metric exporters. Changes: - Changed 4 metrics from Int64ObservableUpDownCounter to Int64ObservableCounter: * db.client.connections.timeouts * db.client.connections.waits * db.client.connections.hits * db.client.connections.misses - Added inline comments explaining why these are counters (monotonic) - Fixed spacing bug in statusAttr function (double space before err) - Added TestMetricTypes_CodeReview test to document expected metric types - All existing tests pass This is a breaking change for users relying on the previous metric type, but it aligns with OpenTelemetry best practices and enables proper metric aggregation and rate calculations.
Fix issue #3612: Change db.client.connections.timeouts, waits, hits, and misses from Int64ObservableUpDownCounter to Int64ObservableCounter to comply with OpenTelemetry conventions. According to OpenTelemetry semantic conventions, these metrics represent cumulative counts that only increase, so they should be Counters, not UpDownCounters. This allows proper use of rate() functions in Prometheus and other metric exporters. Changes: - Changed 4 metrics from Int64ObservableUpDownCounter to Int64ObservableCounter: * db.client.connections.timeouts * db.client.connections.waits * db.client.connections.hits * db.client.connections.misses - Fixed spacing bug in statusAttr function (double space before err) - Added TestMetricTypes_CodeReview test to document expected metric types - All existing tests pass This is a breaking change for users relying on the previous metric type, but it aligns with OpenTelemetry best practices and enables proper metric aggregation and rate calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3612: Change db.client.connections.timeouts, waits, hits, and misses from Int64ObservableUpDownCounter to Int64ObservableCounter to comply with OpenTelemetry conventions.
According to OpenTelemetry semantic conventions, these metrics represent cumulative counts that only increase, so they should be Counters, not UpDownCounters. This allows proper use of rate() functions in Prometheus and other metric exporters.
Changed metrics:
This is a breaking change for users relying on the previous metric type, but it aligns with OpenTelemetry best practices and enables proper metric aggregation and rate calculations.