fix(ui): keep sidebar user dropdown open#2450
Draft
malinskibeniamin wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix Base UI dropdown content rendering so the sidebar user menu stays open and usable. @SpicyPete
Why
The visible dropdown content was nested inside the Base UI popup element, so focus and menu behavior were attached to a wrapper instead of the rendered menu surface.
How
Render the visible dropdown surface directly through Base UI's
Popup.render, preserving Base UI props, role, focus handling, and Radix-compatible state attributes on the same element.Acceptance Criteria
data-statestyling compatibility.Testing Steps
bun run type:checkbun run lint:check(reports existing repo-wide restricted-import/unused-suppression issues; exit 0)bun run test