ci: fetch BUF_TOKEN from AWS Secrets Manager in proto-generate workflow#2451
Open
ivotron wants to merge 1 commit into
Open
ci: fetch BUF_TOKEN from AWS Secrets Manager in proto-generate workflow#2451ivotron wants to merge 1 commit into
ivotron wants to merge 1 commit into
Conversation
Mirrors the existing AWS-SM pattern in this repo's buf.yml so the BUF_TOKEN repo secret is no longer needed. Once this lands, the repo-level BUF_TOKEN GitHub secret can be deleted; the buf.build token is sourced exclusively from sdlc/prod/github/buf_token in AWS SM, which is the canonical location managed by the DevProd Secret Maintainer (DEVPROD-3054).
ivotron
requested review from
a team,
c-julin,
cjayani and
Copilot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Migrates the proto-generate.yml workflow off the repo-level BUF_TOKEN GitHub secret to AWS Secrets Manager, mirroring the existing pattern in buf.yml. This allows the GH-secret copy to be removed and centralizes the buf.build vbot token in AWS SM.
Changes:
- Adds
id-token: writepermission to enable OIDC-based AWS role assumption. - Adds
configure-aws-credentialsandaws-secretsmanager-get-secretssteps to fetchBUF_TOKENfromsdlc/prod/github/buf_token. - Removes the explicit
env: BUF_TOKENblock from theGenerate protosstep, relying onparse-json-secrets: trueto export it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
proto-generate.ymloff the repo-levelBUF_TOKENGitHub secret and onto AWS Secrets Manager, mirroring the pattern already used bybuf.ymlin this same repo.After this lands, the
BUF_TOKENrepo secret can be deleted — the buf.build vbot token is sourced canonically fromsdlc/prod/github/buf_tokenin AWS SM (managed by the DevProd Secret Maintainer).Context
buf.ymlin this repo —RP_AWS_CRED_BASE_ROLE_NAMEandRP_AWS_CRED_REGIONare already provisioned forredpanda-data/console.parse-json-secrets: trueexports the SM JSON keys as env vars, soBUF_TOKENis set automatically for thetask proto:generatestep — the explicitenv:block becomes redundant.Test plan
Proto generate checkrun succeeds against the new auth path.gh secret delete BUF_TOKEN --repo redpanda-data/consoleand confirm a subsequent proto-touching PR still passesProto generate check.