[v25.2.x] cloud_io: clear scheduling group bw cap when throttling is disabled#30474
Merged
nvartolomei merged 2 commits intoMay 19, 2026
Conversation
When set_disk_max_bandwidth is called with 0 or max to disable throttling, the cap previously set on the scheduling_group via update_io_bandwidth stayed in effect. Set it to an effectively unlimited value so the cap is lifted. Workaround for scylladb/seastar#3370: there is no API to clear the cap, and values at/above the internal max_rate threshold throw, so pass 1 PiB/s which is well below that ceiling and well above any real device. (cherry picked from commit 1e49391)
Co-authored-by: Oren Leiman <1635704+oleiman@users.noreply.github.com> (cherry picked from commit af31719)
nvartolomei
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30319
Conflict details
scoped_remoteands3_imposterlibrary rules — none of the test/bench targets that exist on dev. The cherry-pick wanted to insert the newio_resources_testrule afterdb_s3_imposter_test, which does not exist on v25.2.x. Resolved by appending the newredpanda_cc_gtest(name = "io_resources_test", ...)block after thes3_imposterrule, leaving thes3_imposterrule unchanged, and addingredpanda_cc_gtestto the existingload("//bazel:test.bzl", ...)statement so the new rule resolves.