Skip to content

Replace concat-stream w/ node:stream/consumers - #946

Open
ChristianMurphy wants to merge 1 commit into
remarkjs:mainfrom
ChristianMurphy:refactor/replace-concat-stream
Open

ChristianMurphy wants to merge 1 commit into
remarkjs:mainfrom
ChristianMurphy:refactor/replace-concat-stream

Conversation

@ChristianMurphy

@ChristianMurphy ChristianMurphy commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

Related to unifiedjs/unified-engine#92 and unifiedjs/unified-engine#93.

The MarkdownAsync tests now pipe renderToPipeableStream output into a PassThrough and read it with text() from node:stream/consumers.
Before, they collected it with concat-stream inside a new Promise.
concat-stream leaves devDependencies, and the shared TextDecoder in test.jsx goes too, since nothing else used it.
An error while rendering, such as a throwing rehype plugin, now rejects the test through await text().

Only the tests change.
The published package stays the same.

@github-actions github-actions Bot added the 👋 phase/new Post is being triaged automatically label Sep 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5088035) to head (73e9721).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #946   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines         1787      1778    -9     
  Branches       123       119    -4     
=========================================
- Hits          1787      1778    -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤞 phase/open Post is being triaged manually

Development

Successfully merging this pull request may close these issues.

1 participant