Replace concat-stream w/ node:stream/consumers - #946
Open
ChristianMurphy wants to merge 1 commit into
Open
ChristianMurphy wants to merge 1 commit into
ChristianMurphy wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 1787 1778 -9
Branches 123 119 -4
=========================================
- Hits 1787 1778 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Related to unifiedjs/unified-engine#92 and unifiedjs/unified-engine#93.
The
MarkdownAsynctests now piperenderToPipeableStreamoutput into aPassThroughand read it withtext()fromnode:stream/consumers.Before, they collected it with
concat-streaminside anew Promise.concat-streamleavesdevDependencies, and the sharedTextDecoderintest.jsxgoes too, since nothing else used it.An error while rendering, such as a throwing rehype plugin, now rejects the test through
await text().Only the tests change.
The published package stays the same.