Open
Conversation
Rewrite functions in pg_repack.sql.in by using format() instead of string concatenation.
Previously repack.repack_indexdef would generate CREATE INDEX on the target table or on the temp table depending on the 4th (concurrent_index) argument. If it is true then the table is the target table, otherwise the table is the temp table. This looks counter-intuitive. Instead of table oid just pass table name. It would be a caller responsibility to pass the correct table name.
This introduces the `--use-original-schema` option to allow to create temporary objects in the target table's original schema instead of the `repack` schema. - Replace the `repack.tables` view by the `repack.get_tables()` function to generate DDL statements using the target temporary schema. - Update internal and SQL helper functions to accept target schema name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the
--use-original-schemaoption to allow to create temporary objects in the target table's original schema instead of therepackschema.repack.tablesview by therepack.get_tables()function to generate DDL statements using the target temporary schema.Additionally:
pg_repack.sql.inby usingformat()instead of string concatenation: 735aa86repack.repack_indexdef: pass table name instead of oid: 08ccf05Discussion for additional context:
#475