ci: remove pull_request_target trigger from release-drafter#406
Open
ryantm wants to merge 1 commit into
Open
Conversation
Removes the pull_request_target event trigger from release-drafter to eliminate exposure of the supply-chain-attack pattern exploited in the TanStack NPM compromise. See: https://tanstack.com/blog/npm-supply-chain-compromise-postmortem Autolabeler will no longer run on PRs from forks; release notes are still drafted on push to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recent TanStack NPM supply-chain compromise postmortem describes how an attacker exploited a
pull_request_targetworkflow to exfiltrate secrets via a PR from a fork. Per security policy, we're removingpull_request_targettriggers from all Replit-owned public repos as a precaution — even where the current use looks safe — to eliminate exposure to that attack pattern.Slack thread: https://replit.slack.com/archives/C03FS477T17/p1778588219046429
What changed
Deleted the
pull_request_targettrigger block from.github/workflows/release-drafter.yml. No other changes.Trade-off: the release-drafter autolabeler will no longer run on PRs opened from forks. Release notes are still drafted on push to
main, and the autolabeler still runs on PRs from branches inside this repo via the existingpull_requesttrigger.Test plan
pull_request_target:key, itstypes:list, and the preceding explanatory comment).release-drafter.ymlremains syntactically valid YAML with thepush: branches: [main]andpull_request:triggers intact, so the workflow continues to run on merges tomainand on internal PRs.Revertibility
Safe to revert — single workflow file, no schema or data changes. Re-adding the trigger block restores prior behavior.
~ written by Zerg 👾 (mutated-hydralisk-73a8)