[#2622] Hide bucket time in ramp tooltips - #2624
Open
CYX22222003 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to tooltip formatting and the corresponding Cypress assertions are updated to match the new display behavior.
Pull request overview
Updates RepoSense’s frontend ramp tooltip text to display only the bucket date (not the normalized bucket start timestamp), aligning tooltip semantics with daily/weekly contribution bucketing while keeping all underlying filtering and positioning logic unchanged.
Changes:
- Format ramp tooltip dates as date-only strings (e.g.,
2019-07-24instead of2019-07-24T00:00:00) via a small helper inc-ramp.vue. - Apply the same date-only formatting to weekly tooltip ranges (
startDate till endDate). - Update Cypress E2E assertions that check ramp slice
titleattributes to match the new tooltip format.
File summaries
| File | Description |
|---|---|
| frontend/src/components/c-ramp.vue | Strips time portion from tooltip date strings for daily/weekly ramp tooltips. |
| frontend/cypress/tests/zoomView/zoomView_rampChart.cy.js | Updates expected ramp slice tooltip titles to date-only format. |
| frontend/cypress/tests/chartView/chartView_zoomFeature.cy.js | Updates expected ramp slice tooltip titles to date-only format. |
| frontend/cypress/tests/chartView/chartView_optimiseTimeline.cy.js | Updates expected ramp slice tooltip titles to date-only format. |
| frontend/cypress/tests/chartView/chartView_mergeCommits.cy.js | Updates selectors/expectations relying on ramp slice tooltip titles to date-only format. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
damithc
reviewed
Sep 2, 2026
damithc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @CYX22222003 for the PR. Based on changes to the test files, this PR seems to achieve the intended outcome. No issues from my side.
CYX22222003
enabled auto-merge (squash)
September 4, 2026 09:16
CYX22222003
disabled auto-merge
September 4, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2622
Proposed commit message
Other information
This is a display-only frontend change. The underlying date values used
for filtering, ramp positioning, report generation, and JSON output are
left unchanged.
Tested with:
.\gradlew.bat testFrontend -Pci.\gradlew.bat test --tests "reposense.commits.*" --tests "reposense.parser.LocalDateTimeParserTest"