Skip to content

[#2622] Hide bucket time in ramp tooltips - #2624

Open
CYX22222003 wants to merge 1 commit into
reposense:masterfrom
CYX22222003:fix-ramp-tooltip-date
Open

[#2622] Hide bucket time in ramp tooltips#2624
CYX22222003 wants to merge 1 commit into
reposense:masterfrom
CYX22222003:fix-ramp-tooltip-date

Conversation

@CYX22222003

Copy link
Copy Markdown
Member

Fixes #2622

Proposed commit message

Hide bucket time from ramp tooltips.

Format ramp tooltip dates as date-only values, because the timestamp
shown there represents the daily bucket start rather than an actual
commit timestamp.

Other information

This is a display-only frontend change. The underlying date values used
for filtering, ramp positioning, report generation, and JSON output are
left unchanged.

Tested with:

  • .\gradlew.bat testFrontend -Pci
  • .\gradlew.bat test --tests "reposense.commits.*" --tests "reposense.parser.LocalDateTimeParserTest"

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped to tooltip formatting and the corresponding Cypress assertions are updated to match the new display behavior.

Pull request overview

Updates RepoSense’s frontend ramp tooltip text to display only the bucket date (not the normalized bucket start timestamp), aligning tooltip semantics with daily/weekly contribution bucketing while keeping all underlying filtering and positioning logic unchanged.

Changes:

  • Format ramp tooltip dates as date-only strings (e.g., 2019-07-24 instead of 2019-07-24T00:00:00) via a small helper in c-ramp.vue.
  • Apply the same date-only formatting to weekly tooltip ranges (startDate till endDate).
  • Update Cypress E2E assertions that check ramp slice title attributes to match the new tooltip format.
File summaries
File Description
frontend/src/components/c-ramp.vue Strips time portion from tooltip date strings for daily/weekly ramp tooltips.
frontend/cypress/tests/zoomView/zoomView_rampChart.cy.js Updates expected ramp slice tooltip titles to date-only format.
frontend/cypress/tests/chartView/chartView_zoomFeature.cy.js Updates expected ramp slice tooltip titles to date-only format.
frontend/cypress/tests/chartView/chartView_optimiseTimeline.cy.js Updates expected ramp slice tooltip titles to date-only format.
frontend/cypress/tests/chartView/chartView_mergeCommits.cy.js Updates selectors/expectations relying on ramp slice tooltip titles to date-only format.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@CYX22222003
CYX22222003 requested a balanced review from Copilot September 2, 2026 16:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CYX22222003
CYX22222003 requested a review from damithc September 2, 2026 16:27

@damithc damithc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CYX22222003 for the PR. Based on changes to the test files, this PR seems to achieve the intended outcome. No issues from my side.

@CYX22222003
CYX22222003 enabled auto-merge (squash) September 4, 2026 09:16
@CYX22222003
CYX22222003 disabled auto-merge September 4, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ramp tooltip timestamp can be misleading for daily commit buckets

3 participants