Skip to content

fix(server): pass --no-color to data_shape git grep (#858)#935

Open
gitcommit90 wants to merge 1 commit into
repowise-dev:mainfrom
gitcommit90:fix/issue-858-data-shape-no-color
Open

fix(server): pass --no-color to data_shape git grep (#858)#935
gitcommit90 wants to merge 1 commit into
repowise-dev:mainfrom
gitcommit90:fix/issue-858-data-shape-no-color

Conversation

@gitcommit90

Copy link
Copy Markdown

Summary

Pass --no-color to data_shape live-grep so exclusion filters survive color.ui=always.

Changes

Closes #858

With color.ui=always, git wraps paths in ANSI escapes so
_grep_identifier_files exclusion filtering and reads miss real files.
Match the _code_rationale.py fix from repowise-dev#825. Closes repowise-dev#858.
@repowise-bot

repowise-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

✅ Health: 7.5 (unchanged)

📋 At a glance
2 hotspots touched · 1 new finding introduced · 2 files with recent fix history.

Files & modules (2)
  • packages (1 file)
    • .../tool_answer/data_shape.py
  • tests (1 file)
    • .../mcp/test_answer_data_shape.py

🗺️ Change map

flowchart LR
  subgraph PR ["Changed in this PR (1 with dependents)"]
    f_packages_server_src_repowise_server_mcp_server_tool_answer_data_shape_py[".../tool_answer/data_shape.py 🔥"]:::changed
  end
  f_packages_server_src_repowise_server_mcp_server_tool_answer_answer_py[".../tool_answer/answer.py"]
  f_packages_server_src_repowise_server_mcp_server_tool_answer_data_shape_py --> f_packages_server_src_repowise_server_mcp_server_tool_answer_answer_py
  classDef changed fill:#dbeafe,stroke:#1d4ed8,color:#1e3a5f
  classDef warn fill:#fef3c7,stroke:#b45309,color:#78350f
  classDef guard fill:#dcfce7,stroke:#15803d,color:#14532d
Loading

Solid arrows: code that imports the changed files (1 direct dependent, from the last indexed snapshot). Dashed: history/tests.

🩹 Review priority (files here with the most recent bug-fix history — defects cluster, so review these first)

🔎 More signals (1)

🔥 Hotspots touched (2)

  • .../mcp/test_answer_data_shape.py — 3 commits/90d, 0 dependents · primary owner: Raghav Chamadiya (86%)
  • .../tool_answer/data_shape.py — 3 commits/90d, 2 dependents · primary owner: Raghav Chamadiya (96%)

📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-19 16:34 UTC
Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot

@swati510

Copy link
Copy Markdown
Collaborator

Thank you for picking this up, and thank you especially for carrying over the explanatory comment from the _code_rationale.py fix in #825. The source change here is exactly right, and I verified by hand that --no-color suppresses the escape codes both for color.ui = always and for the narrower color.grep = always.

I am going to land #860 instead, because its regression test asserts on the higher-level _grep_identifier_files function rather than on the raw subprocess output, which pins down the behaviour that the callers actually depend on. I would like to bring your comment across to that pull request, though, because a bare flag with no explanation is very easy for a future tidy-up to delete, so your work here is not going to waste. Thank you again for the careful fix and for the regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] data_shape live-grep: add --no-color so exclusion filter survives color.ui=always

2 participants