Skip to content

fix: add error handler to searchIndexService.initialize() call #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RUKAYAT-CODER merged 1 commit into from
Jul 29, 2026
Merged

fix: add error handler to searchIndexService.initialize() call #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
apiClient,
getCacheStatus,
getRevalidatingCacheKeys,
subscribeToCacheStatus,

Check failure on line 32 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Module '"./src/services/api"' has no exported member 'subscribeToCacheStatus'. Did you mean to use 'import subscribeToCacheStatus from "./src/services/api"' instead?
} from './src/services/api';
import { warmCriticalCaches } from './src/services/cacheWarming';
import {
Expand All @@ -47,7 +47,7 @@
removeNotificationListener,
setupForegroundBadgeSync,
} from './src/services/pushNotifications';
import { requestQueue } from './src/services/requestQueue';

Check failure on line 50 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find module './src/services/requestQueue' or its corresponding type declarations.
import { searchIndexService } from './src/services/searchIndex';
import { checkSessionValidity, initializeSecureStorage } from './src/services/secureStorage';
import socketService from './src/services/socket';
Expand All @@ -60,7 +60,7 @@
subscribeToHydrationResetToast,
} from './src/store/persistence';
import { handleCacheVersionUpdate } from './src/utils/cacheVersioning';
import { requireEnvVariables } from './src/utils/env';

Check failure on line 63 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find module './src/utils/env' or its corresponding type declarations.
import { appLogger } from './src/utils/logger';

// Keep the splash screen visible while we fetch resources
Expand Down Expand Up @@ -217,7 +217,7 @@
const fontStart = Date.now();
await Promise.all([
fontService.loadFonts(CRITICAL_FONTS),
Asset.loadAsync(CRITICAL_ASSETS),

Check failure on line 220 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Argument of type 'readonly [any, any, any]' is not assignable to parameter of type 'string | number | string[] | number[]'.
]);
appLogger.infoSync(`[App] Critical fonts & assets loaded in ${Date.now() - fontStart}ms`);
await fontService.loadFonts(CRITICAL_FONTS);
Expand Down Expand Up @@ -358,8 +358,8 @@
Object.entries(capabilities).forEach(([feature, info]) => {
if (feature !== 'checkedAt' && 'status' in info) {
// #807: isFeatureType narrows string key to FeatureType
if ((Object.values(FeatureType) as string[]).includes(feature)) {

Check failure on line 361 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find name 'FeatureType'.
degradationStore.setFeatureStatus(feature as FeatureType, info.status);

Check failure on line 362 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find name 'FeatureType'.
}
}
});
Expand Down Expand Up @@ -404,8 +404,8 @@
Object.entries(capabilities).forEach(([feature, info]) => {
if (feature !== 'checkedAt' && 'status' in info) {
// #807: isFeatureType narrows string key to FeatureType
if ((Object.values(FeatureType) as string[]).includes(feature)) {

Check failure on line 407 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find name 'FeatureType'.
degradationStore.setFeatureStatus(feature as FeatureType, info.status);

Check failure on line 408 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find name 'FeatureType'.
}
}
});
Expand Down Expand Up @@ -467,7 +467,7 @@
// Issue #820: read store directly rather than closed-over component state.
const store = useNotificationStore.getState();
store.addNotification({
id: notification.request.identifier,

Check failure on line 470 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Object literal may only specify known properties, and 'id' does not exist in type 'Omit<StoredNotification, "id" | "read" | "receivedAt">'.
type: (notification.request.content.data?.type as any) ?? 'general',
title: notification.request.content.title ?? '',
body: notification.request.content.body ?? '',
Expand All @@ -494,7 +494,9 @@
warmCriticalCaches();

// Build the offline search index from cached/fetched course data.
searchIndexService.initialize();
searchIndexService.initialize().catch((err: unknown) => {
appLogger.errorSync('[App] searchIndexService.initialize failed', err as Error);
});
});

// Cleanup on unmount
Expand Down Expand Up @@ -599,7 +601,7 @@
<AuthProvider>
<StatusBar style={theme === 'dark' ? 'light' : 'dark'} />
<CacheRevalidationBanner />
<ScreenErrorBoundary screenName="AppNavigator">

Check failure on line 604 in App.tsx

View workflow job for this annotation

GitHub Actions / Syntax & Type Check 

Cannot find name 'ScreenErrorBoundary'.
<AppNavigator />
</ScreenErrorBoundary>
<NotificationPermissionExplanationSheet />
Expand Down
Loading