feat(ci): add contract bindings auto-regeneration after deploy (#788) - #828
feat(ci): add contract bindings auto-regeneration after deploy (#788)#828Kingsley4867 wants to merge 1 commit into
Conversation
|
@kodinaka30-ship-it is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Kingsley4867 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
📝 WalkthroughWalkthroughChangesContract binding automation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/contract-deploy.yml:
- Around line 73-76: Pin peter-evans/create-pull-request in the Create Pull
Request with Updated Bindings step to the vetted full commit SHA instead of the
mutable v6 tag in both .github/workflows/contract-deploy.yml lines 73-76 and
.github/workflows/contract-smoke.yml lines 72-75.
- Around line 35-39: Install the affected package’s locked Node dependencies
before binding generation and TypeScript checking: add the appropriate npm
install step before gen:bindings and npx tsc in both
.github/workflows/contract-deploy.yml (lines 35-39) and
.github/workflows/contract-smoke.yml (lines 56-60), using npm ci or the
repository’s required package-lock installation flow.
In `@scripts/generate-contract-bindings.sh`:
- Around line 84-95: Update the frontend TypeScript validation block guarded by
SKIP_TS_CHECK to fail explicitly when npx is unavailable, and invoke the tsc
command directly in the conditional so its failure reaches the existing failure
message instead of being terminated by set -e before $? is checked. Preserve the
current success and failure outputs and exit behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 710f25f2-656f-4dbc-a63a-fb2bdf90c2d0
📒 Files selected for processing (4)
.github/workflows/contract-deploy.yml.github/workflows/contract-smoke.ymldocs/CONTRACT_BINDINGS.mdscripts/generate-contract-bindings.sh
|
Hi @Kingsley4867, This PR could not be merged because it has merge conflicts with the target branch. Please resolve the merge conflicts, push the updated changes, and the PR can be reviewed and merged. Thank you! |
|
Please take your time and check it well and approve as it's has been resolved and no conflicts with base branch |
1 similar comment
|
Please take your time and check it well and approve as it's has been resolved and no conflicts with base branch |
|
Hi @ritik4ever , just following up on my submitted PR. I'd appreciate it if you could review. If everything looks good, I'd be grateful if you could approve it and award the associated points. Thank you! |
Closes #788
What changed
Testing done
Related issues
Closes #788
Checklist