Upgrade River + River Pro and support SQLite - #657
Open
brandur wants to merge 1 commit into
Open
Conversation
brandur
force-pushed
the
brandur-pro-sqlite-support
branch
from
August 20, 2026 08:33
bf53337 to
7d4dbb8
Compare
Bumps River to v0.44.0, River Pro to v0.27.0, and makes a couple tweaks to make sure that River Pro features are working in conjunction with SQLite.
brandur
force-pushed
the
brandur-pro-sqlite-support
branch
from
August 20, 2026 08:37
7d4dbb8 to
4514901
Compare
bgentry
approved these changes
Aug 20, 2026
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
LGTM other than my thought that it looks like some of this belongs in River itself to keep the drivers identical. I assume we may be missing some assertions on this at that layer to ensure conformance?
Comment on lines
+879
to
+882
| errors := internal.Errors | ||
| if errors == nil { | ||
| errors = []rivertype.AttemptError{} | ||
| } |
Contributor
There was a problem hiding this comment.
Hmm, shouldn't this be able to stay the same while this defaulting logic is moved into the driver so the sqlite driver behaves the same as the others?
Collaborator
Author
There was a problem hiding this comment.
Ah good point. Opened riverqueue/river#1354.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps River to v0.44.0, River Pro to v0.27.0, and makes a couple tweaks
to make sure that River Pro features are working in conjunction with
SQLite.