feat(examples): pong & agario examples

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
rivetkit-serverless	Error		Dec 20, 2025 8:03pm

3 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
rivet-cloud	Ignored		Dec 20, 2025 8:03pm
rivet-inspector	Ignored	Preview	Dec 20, 2025 8:03pm
rivet-site	Ignored	Preview	Dec 20, 2025 8:03pm

[NathanFlurry]

• feat(examples): pong & agario examples #3662 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Pull Request Review: Pong & Agario Game Examples

This PR adds two excellent game examples demonstrating Rivet Actors for real-time multiplayer games. Below are my findings:

✅ Strengths

1. Good educational value - clearly demonstrates Rivet Actor patterns
2. Clean separation of concerns - backend logic separated from frontend
3. Proper lifecycle management - correct onWake/onSleep for interval cleanup
4. Type safety - good use of shared TypeScript types
5. Canvas rendering optimization - proper culling in Agario

🐛 Critical Issues

Agario - State mutation (registry.ts:146-224)

• updateGame mutates players from Object.values which is fragile
• Fix: Iterate over c.state.players directly or document intent

Agario - Race condition (registry.ts:77-108)

• onConnect/onDisconnect await matchmaker but no error handling
• Fix: Add error handling for matchmaker calls

⚠️ Medium Issues

Pong - Matchmaker scalability (registry.ts:17-51)

• Only handles 2 players, overwrites waitingConnId
• Fix: Use array/queue for waiting players

Pong - Match ID collision (registry.ts:34)

• Date.now() can collide in same millisecond
• Fix: Use UUID or add Math.random()

📝 Code Quality Issues

1. README path error (game-pong/README.md:43) - links to game-physics instead of game-pong
2. Unused exports - VIEWPORT_WIDTH, VIEWPORT_HEIGHT, PlayerInput type in agario/constants.ts
3. No input validation - setTarget and setInput trust client data
4. Inconsistent type checking - agario uses satisfies, pong does not

⚡ Performance Notes

1. Agario broadcasts 210 objects at 60 FPS to 10 players (600 broadcasts/sec)
2. Player collision is O(n²) - acceptable for 10 players
3. Consider requestAnimationFrame optimization for frontend

🔒 Security Concerns

1. No rate limiting - clients can spam actions (DoS risk)
2. Client coordinates not validated - poor practice for examples

🎯 Recommendations

Must Fix:

1. Correct README path in pong
2. Add error handling for matchmaker
3. Document or fix matchmaker scalability

Should Fix:
4. Add input validation
5. Remove unused types/constants
6. Use UUID for match IDs

Summary: Solid educational examples with good patterns. Issues are mostly edge cases and quality improvements. Recommended: Approve with minor changes.

Review by Claude Code based on CLAUDE.md