docs(agents): refine AGENTS.md#2308
Merged
Merged
Conversation
…on guidance - Add §2 Repository Architecture: full core module table and key design patterns - Add §4 Test Conventions (promoted from §3a): AAA, class grouping, parametrize, doctest rules - Add §6 Deprecated Module Aliases: keypoint → key_points migration guide - Add §7 Deprecating APIs: mechanism table (warn_deprecated, deprecated_parameter, @deprecated) - Add Extending Detections and Adding Model Connector subsections to §5 - Add Runtime Dependencies section with lazy-import rule - Add baseline/diff workflow to §10 Before You Commit - Add CONTRIBUTING.md conflict-resolution rule at top - mypy now noted as enforced by pre-commit (not just encouraged) - Section numbers renumbered throughout (old 3→new 3, 3a→4, 4→8, 5→9, 6→10) --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2308 +/- ##
=======================================
Coverage 80% 80%
=======================================
Files 66 66
Lines 8787 8787
=======================================
Hits 7046 7046
Misses 1741 1741 🚀 New features to boost your workflow:
|
Replace module and deprecation tables with bullet lists; merge bugs/refactoring sections; trim filler prose. All technical substance preserved. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Fenced ASCII tree makes filesystem hierarchy explicit and more token-efficient for LLM consumers. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands AGENTS.md into a more comprehensive contributor/agent reference, documenting repository architecture, coding conventions, testing expectations, and API extension/deprecation patterns to better align day-to-day contributions with the supervision codebase structure.
Changes:
- Adds a detailed repository architecture/module map and highlights key design patterns centered around
Detections. - Codifies conventions for formatting, typing, dependencies, doctests, and test structure.
- Documents guidance for extending
Detections, adding model/VLM connectors, and deprecating/refactoring public APIs.
…TING.md AGENTS.md: drop redundant sections already in CONTRIBUTING.md (branching, full code style, full test structure, perf prose); keep agent-failure-mode rules absent from CONTRIBUTING.md (heading depth, mypy enforcement, doctest determinism, lazy-import pattern). CONTRIBUTING.md: fix stale "no mypy" claim (mypy is enforced by pre-commit); add Performance section; add deprecated keypoint alias note. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
AAA structure, class grouping, parametrize shape, and test docstring rules were derived from observed bad agent behaviour and belong in AGENTS.md, not delegated to CONTRIBUTING.md. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
CONTRIBUTING.md owns the content; AGENTS.md flags the agent-failure-mode and links directly to the section rather than duplicating the rules. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Remove obvious import example (§4) and constants block (§6 Detections); fold into prose. Connector template and warn_deprecated call are repo-specific — kept. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Borda
commented
Jun 10, 2026
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
…eprecate deprecated_parameter handles old→new param renaming only; pydeprecate @deprecated still required on the function when function itself is deprecated. Expand third bullet to include methods. --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
--- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…d placement - Fix LineZone listed under detection/tools/ — lives in detection/line_zone.py; add as separate tree entry - Fix unsafe git stash baseline: save refs/stash before push, only pop if ref changed after - Clarify warn_deprecated goes in deprecated module's own __init__.py, not supervision/__init__.py - Item #4 (style: commit type) already addressed: commit type list removed; CONTRIBUTING.md cross-ref covers it --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly expands and clarifies the
AGENTS.mdguidelines for contributors and AI agents, bringing them into closer alignment with the project's architecture and conventions. The updates introduce detailed descriptions of the repository structure, coding and testing standards, and explicit rules for extending, deprecating, and testing APIs. The document now provides a comprehensive, structured reference for both human and AI contributors.Key improvements and additions:
Repository Structure and Design Patterns
src/supervision/, including the purpose of each, and clarified the use ofDetectionsas the central data structure. Key design patterns (e.g., vectorization, extensibility, stateless functions) are now explicitly documented.Coding Standards and Dependencies
mypyis enforced. Provided a list of required runtime dependencies and clarified lazy-import rules for heavy frameworks.Testing and Doctest Conventions
Feature Implementation and API Extension
Detectionswith new metadata, including the use of constants fromconfig.py. Provided a template for adding new model connectors and clarified where VLM connectors should reside.Deprecation and Refactoring
Test Baseline and Pre-Commit Process