feat: Add specific timeframe support with --start-time and --end-time

[arikalon1]

Summary

This PR adds support for specifying absolute time ranges for KRR metrics queries, addressing the feature request in #474.

Changes

1. robusta_krr/core/models/config.py

• Added start_time and end_time optional datetime fields to the Settings class
• Added a pydantic field validator to parse ISO 8601 datetime strings (with support for Z suffix and timezone offsets)

2. robusta_krr/core/abstract/strategies.py

• Updated get_query_time_range() method in BaseStrategy to check for start_time and end_time
• When both are provided, uses them directly (absolute timeframe mode)
• When not provided, falls back to original behavior using history_duration (relative timeframe mode)

Usage

Users can now specify a specific time range in two ways:

Via Configuration File

start_time: "2025-09-05T10:00:00Z"
end_time: "2025-09-08T10:00:00Z"

Programmatically

settings = Settings(
    start_time="2025-09-05T10:00:00Z",
    end_time="2025-09-08T10:00:00Z"
)

Why This Feature?

As described in #474, users need to analyze specific historical time periods (like past peak events) without querying all data from that time until now. This is especially useful for:

• Analyzing historical peaks without overloading Prometheus/Grafana
• Investigating specific incidents or time periods
• Running targeted analyses without affecting current recommendations

Testing

• Unit tests for datetime parsing
• Integration test with absolute timeframe
• Verification that relative timeframe (history_duration) still works

Related Issues

Closes #474

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a comprehensive refactoring of the strategy and configuration layers. It replaces tightly-scoped models with generic public entities in the strategy system, adds new data models (K8sObjectData, HPAData, HistoryData), and restructures the configuration from a monolithic Config class into modular, composable settings objects with ISO8601 datetime parsing support.

Changes

Cohort / File(s)	Change Summary
Strategy System Refactoring robusta_krr/core/abstract/strategies.py	Replaced multiple old strategy-specific and tightly-coupled data models with new generic public entities including HistoryData, RunResult, PodsTimeData, StrategySettings, MetricsPodData, ResourceHistoryData, HistoryRange, K8sObjectData, and HPAData. Updated BaseStrategy abstract interface with new public methods find_runs and get_query_time_range. Removed legacy type aliases (SelfRR, SelfBS, ArrayNx2) and old properties. Significant public API surface overhaul affecting strategy and data model definitions.
Configuration System Refactoring robusta_krr/core/models/config.py	Replaced monolithic Config class with modular configuration built on new PercentileSelectorSettings, PrometheusSettings, ThanoSettings, VictoriaMetricsSettings, CostSettings, and central Settings model. Added ISO8601 datetime parsing via field\_validator for start_time and end_time fields. Introduced _init_kube_config method and init_custom_certificate function for certificate management. Removed legacy kube client handling and singleton pattern (_config proxy).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/specific-timeframe-474

---

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3acc116 and 3ee5b28.

📒 Files selected for processing (2)

• robusta_krr/core/abstract/strategies.py
• robusta_krr/core/models/config.py

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}