Skip to content

fix memory leaks #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aantn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix memory leaks #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,10 +598,10 @@ func Start(conf *config.Config, eventHandler handlers.Handler) {

func newResourceController(client kubernetes.Interface, eventHandler handlers.Handler, informer cache.SharedIndexInformer, resourceType string, apiVersion string, kubewatchEventsMetrics *prometheus.CounterVec) *Controller {
queue := workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter())
var newEvent Event
var err error
informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: func(obj interface{}) {
var newEvent Event
var err error
var ok bool
newEvent.namespace = "" // namespace retrived in processItem incase namespace value is empty
newEvent.key, err = cache.MetaNamespaceKeyFunc(obj)
Expand All @@ -620,6 +620,8 @@ func newResourceController(client kubernetes.Interface, eventHandler handlers.Ha
kubewatchEventsMetrics.WithLabelValues(resourceType, "create").Inc()
},
UpdateFunc: func(old, new interface{}) {
var newEvent Event
var err error
var ok bool
newEvent.namespace = "" // namespace retrived in processItem incase namespace value is empty
newEvent.key, err = cache.MetaNamespaceKeyFunc(old)
Expand All @@ -642,6 +644,8 @@ func newResourceController(client kubernetes.Interface, eventHandler handlers.Ha
kubewatchEventsMetrics.WithLabelValues(resourceType, "update").Inc()
},
DeleteFunc: func(obj interface{}) {
var newEvent Event
var err error
var ok bool
newEvent.namespace = "" // namespace retrived in processItem incase namespace value is empty
newEvent.key, err = cache.DeletionHandlingMetaNamespaceKeyFunc(obj)
Expand Down
3 changes: 2 additions & 1 deletion pkg/handlers/flock/flock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,11 @@ func postMessage(url string, flockMessage *FlockMessage) error {
req.Header.Add("Content-Type", "application/json")

client := &http.Client{}
_, err = client.Do(req)
resp, err := client.Do(req)
if err != nil {
return err
}
defer resp.Body.Close()

return nil
}
3 changes: 2 additions & 1 deletion pkg/handlers/lark/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,10 @@ func postMessage(url string, textMessage *TextMessage) error {
req.Header.Add("Content-Type", "application/json")

client := &http.Client{}
_, err = client.Do(req)
resp, err := client.Do(req)
if err != nil {
return err
}
defer resp.Body.Close()
return nil
}
3 changes: 2 additions & 1 deletion pkg/handlers/mattermost/mattermost.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,11 @@ func postMessage(url string, mattermostMessage *MattermostMessage) error {
req.Header.Add("Content-Type", "application/json")

client := &http.Client{}
_, err = client.Do(req)
resp, err := client.Do(req)
if err != nil {
return err
}
defer resp.Body.Close()

return nil
}
3 changes: 2 additions & 1 deletion pkg/handlers/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,11 @@ func postMessage(url string, webhookMessage *WebhookMessage) error {
req.Header.Add("Content-Type", "application/json")

client := &http.Client{}
_, err = client.Do(req)
resp, err := client.Do(req)
if err != nil {
return err
}
defer resp.Body.Close()

return nil
}
Loading