fix: release OpenSSL peer certificates after authentication - #294
Draft
rgerhards wants to merge 1 commit into
Draft
fix: release OpenSSL peer certificates after authentication#294rgerhards wants to merge 1 commit into
rgerhards wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SSL_get_peer_certificate()on every peer-authentication exit pathWhy
OpenSSL returns an owned
X509reference fromSSL_get_peer_certificate(). The peer-authentication path retained that reference after every certificate-authenticated connection, causing per-connection memory growth.Impact
This changes only OpenSSL peer-certificate cleanup. Authentication behavior and the public ABI are unchanged.
Checks
make -j60 check: 29 passed, 1 skippedtls-basic-vg.sh: passedSummary by cubic
Fixes a memory leak by releasing the OpenSSL peer certificate after authentication and makes the TLS Valgrind test fail on definite leaks. No behavior or ABI changes.
X509returned bySSL_get_peer_certificate()on all peer-auth exit paths.Written for commit 96e23cc. Summary will update on new commits.