fix: free OpenSSL state after failed outbound TLS setup - #295
Draft
rgerhards wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SSL_set_bio()SSLobject and clear the stored pointer whenever outbound TLS initialization failsWhy
The failed outbound handshake path freed the local BIO pointer but retained the
SSLobject. AfterSSL_set_bio(), however, the SSL object owns that BIO. This both leaked the SSL allocation graph and left cleanup ownership inconsistent.Impact
Failed outbound TLS setup now releases its OpenSSL state and leaves
pThis->sslnull. Successful connections and the public ABI are unchanged.Checks
make -j60 check: 30 passed, 1 skippedSummary by cubic
Fixes memory leak and BIO ownership after failed outbound TLS setup with OpenSSL. Failed handshakes now release all OpenSSL state and leave pThis->ssl null; successful connections are unchanged.
Written for commit bb19790. Summary will update on new commits.