Skip to content

JRuby: keep the whole character after an invalid escape #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
Sep 29, 2026
Merged

JRuby: keep the whole character after an invalid escape #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/src/json/ext/StringDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ private void handleEscapeSequence(ThreadContext context) throws IOException {
break;
default:
if (allowInvalidEscape) {
append(character);
writeUtf8Char(character);
} else {
throw invalidEscape(context);
}
Expand Down
6 changes: 6 additions & 0 deletions test/json/json_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,12 @@ def test_parse_invalid_escape
assert_equal "foo", parse(%("fo\\o"), allow_invalid_escape: true)
end

def test_parse_invalid_escape_non_ascii
assert_equal "caf\u00e9", parse(%("caf\\\u00e9"), allow_invalid_escape: true)
assert_equal "\u3042", parse(%("\\\u3042"), allow_invalid_escape: true)
assert_equal "\u{1F600}", parse(%("\\\u{1F600}"), allow_invalid_escape: true)
end

def test_parse_arrays
assert_equal([1,2,3], parse('[1,2,3]'))
assert_equal([1.2,2,3], parse('[1.2,2,3]'))
Expand Down
Loading