Repository navigation
Use rb_len_t for String and Array lengths in the extension - #824
Merged
Merged
Conversation
It falls back to long on Ruby versions that do not define HAVE_RB_LEN_T, so the change also builds there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A cast to long would cut these lengths to 32 bits before they reach rb_str_new on mswin once rb_len_t widens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby master added
rb_len_tas the type of String and Array lengths (https://bugs.ruby-lang.org/issues/22400). Psych still keeps the length of the tag directives array in along, and casts the lengths it gets from libyaml and libfyaml tolongbefore creating Strings. Both would truncate on mswin oncerb_len_twidens.This switches them to
rb_len_t.psych.hfalls back totypedef long rb_len_twhenHAVE_RB_LEN_Tis not defined, so older Ruby builds the same code as before.I ran
rake compileandrake testwith Ruby 3.3.12 and 4.1.0dev on x64-mswin64, both of which predaterb_len_t. The libfyaml backend does not build on Windows, so it is left to the libfyaml workflow.Generated with Claude Code