Resolve versions and tags in rb install through the binary index - #11
Merged
Conversation
cache.ruby-lang.org now publishes pub/ruby/binaries/index.json, so `rb install 4.0.5` or `rb install ruby-dev` can resolve a package without a zip path. The newest matching x64-mswin64_140 build wins by version, reissue revision and commit date regardless of feed order, the download is verified against the recorded sha256, and an unsigned build installs with a warning. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Unit coverage for the page parsing and order-independent selection, Integration coverage for the full install with the feed redirected to a local file via RBMANAGER_INDEX_URL and the zip served from loopback, and a Network-gated check that the published index still parses and resolves. Cases 99-117 in docs/test-plan.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rb installso far required a zip path or URL. cache.ruby-lang.org now publishespub/ruby/binaries/index.json(ruby/actions#137), so a version or tag can resolve to a package directly:Resolution goes through each build's
tags, filtered tox64-mswin64_140. The newest match wins by version, reissue revision and commit date regardless of feed order, matching the revision-awareResolvefor installed rubies from #8. The download is verified against the recordedsha256, an unsigned build installs with a warning, and aschemaother than 1 asks to upgrade rb. Pagination throughnextis implemented.RBMANAGER_INDEX_URLredirects the feed for tests, which run against a local file and a loopback zip server.Verified end to end against the live index (
rb install 4.1-dev, thenruby -v).🤖 Generated with Claude Code