Change parsing of the CPU block to have optional mpuPresent and#301
Open
xoriath wants to merge 1 commit intorust-embedded:masterfrom
Open
Change parsing of the CPU block to have optional mpuPresent and#301xoriath wants to merge 1 commit intorust-embedded:masterfrom
xoriath wants to merge 1 commit intorust-embedded:masterfrom
Conversation
burrbull
reviewed
Mar 16, 2026
922869a to
5b31d36
Compare
fpuPresent elements Per the SVD schema; these 2 elements are actually optional. However the documentation page for the schema incorrectly claims them to be required. Modify the parser to allow these to be optional when parsing. Fixes rust-embedded#300
5b31d36 to
e97eeef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fpuPresent elements
Per the SVD schema; these 2 elements are actually optional. However the documentation page for the schema incorrectly claims them to be required.
Modify the parser to allow these to be optional when parsing.
Fixes #300