feat: Provide an option to not show derives near the ADT for "Goto Implementations" or "Implementations" codelens#20186
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Oct 28, 2025
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
goto-impl-no-derive
branch
from
44ae90a to
410da90
Compare
ChayimFriedman2
force-pushed
the
goto-impl-no-derive
branch
from
410da90 to
c663c54
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
goto-impl-no-derive
branch
from
c663c54 to
4e9eef2
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@rust-lang/rust-analyzer do we want this? |
Member
Yeah, at least I'm willing to use this feature, as it's quite irritating for me when I have to move the cursor from those derive impls with extra keystrokes in a search result window 😄 |
ShoyuVanilla
approved these changes
Oct 27, 2025
Member
|
Sounds fine to me as well as long as the default for this remains false |
…tations" or "Implementations" codelens I don't do it by default, for three reasons: (1) it's more expensive, (2) I actually quite like seeing the derives, and they may expand to no impl/more than one impl, (3) if rust-lang#19130 will ever be merged this will become even more useful. Even a config might be too much, but it was fun and easy to code so I did that.
ChayimFriedman2
force-pushed
the
goto-impl-no-derive
branch
from
4e9eef2 to
4fddcc6
Compare
Collaborator
|
Contributor
Author
|
Let's merge this then! |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't do it by default, for three reasons: (1) it's more expensive, (2) I actually quite like seeing the derives, and they may expand to no impl/more than one impl, (3) if #19130 will ever be merged this will become even more useful.
Even a config might be too much, but it was fun and easy to code so I did that. CC @rust-lang/rust-analyzer - feel free to close this PR if you think otherwise.
Closes #20016.