Do not re-query source roots per crate in analysis-stats#21788
Merged
Veykril merged 1 commit intorust-lang:masterfrom Mar 9, 2026
Merged
Do not re-query source roots per crate in analysis-stats#21788Veykril merged 1 commit intorust-lang:masterfrom
Veykril merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
This could still report more memory than actually used because we populate item trees we don't need. The problem is that accurate crate discovery requires def map, and we compute it after... |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ideal as we may pick a crate that analysis is not actually using but we do not encode targets in the crate graph so we can't really tell what main library crate will be