Skip to content

Fix off-by-one staging output when testing the library #149724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 7, 2025
Merged

Fix off-by-one staging output when testing the library #149724

bors merged 1 commit into from
Dec 7, 2025

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 6, 2025

It seems generally useful to store the Mode in Cargo, I remember thinking a few times that it would be useful in other places.

Fixes: #149558

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 6, 2025
@Kobzol Kobzol mentioned this pull request Dec 6, 2025
Closed
jieyouxu
jieyouxu approved these changes Dec 7, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Dec 7, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 7, 2025

📌 Commit 7fdf066 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 7, 2025
Merged
bors added a commit that referenced this pull request Dec 7, 2025
@bors
Auto merge of #149729 - matthiaskrgr:rollup-25plwn0, r=matthiaskrgr
aa30176 
Rollup of 4 pull requests

Successful merges:

 - #147136 (Add warn-by-default lint for visibility on `const _` declarations)
 - #149498 (Tidying up `tests/ui/issues` tests [1/N])
 - #149721 (rustc book: fix `*-pc-windows-msvc` link label in sidebar)
 - #149724 (Fix off-by-one staging output when testing the library)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1eef811 into rust-lang:main Dec 7, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 7, 2025
@rust-timer
Unrolled build for #149724
a478271 
Rollup merge of #149724 - Kobzol:libstd-text-staging, r=jieyouxu

Fix off-by-one staging output when testing the library

It seems generally useful to store the `Mode` in `Cargo`, I remember thinking a few times that it would be useful in other places.

Fixes: #149558

r? `@jieyouxu`
@rustbot rustbot added this to the 1.94.0 milestone Dec 7, 2025
@Kobzol Kobzol deleted the libstd-text-staging branch December 7, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

x test library/core stage is off-by-one from its own internal count

4 participants

@Kobzol @jieyouxu @bors @rustbot