Rollup of 4 pull requests#156864
Closed
jhpratt wants to merge 20 commits into
Closed
Conversation
…hods, r=fmease Fix jump to def link generation on primitive type associated methods Fixes rust-lang#156707. Interestingly enough, the inference fails on primitive type, so instead I go around a bit by generating a `PrimitiveType` and then tweak a bit the `href` generation. r? @fmease
…=SimonSapin Add unstable Share trait Tracking issue: rust-lang#156756 This adds an initial unstable `Share` trait for clone-as-alias types, as part of the 2026 ergonomic ref-counting project goal. ```rust pub trait Share: Clone { fn share(&self) -> Self { Clone::clone(self) } } ``` This PR adds a separate unstable feature gate: ```rust #![feature(share_trait)] ``` and places the trait next to `Clone` in `core::clone`. Implemented initial impls: - `impl<T: ?Sized> Share for &T` - `impl<T: ?Sized, A: Allocator + Clone> Share for Rc<T, A>` - `impl<T: ?Sized, A: Allocator + Clone> Share for Arc<T, A>` - `impl<T> Share for std::sync::mpsc::Sender<T>` - `impl<T> Share for std::sync::mpsc::SyncSender<T>` The PR deliberately does not add `Share` to the prelude. r? @nikomatsakis @rustbot label F-ergonomic_clones
Add `#[doc(alias = "phi")]` for float `GOLDEN_RATIO` constants - Adds "phi" doc alias for `f16`, `f32`, `f64`, and `f128` I knew this constant was stabilized but I couldn't remember what it was called. Searching "phi" in the docs only surfaces the π constant, `is_ascii_graphic`, and `spin_loop_hint` methods. This alias would make it much easier to find. https://doc.rust-lang.org/nightly/std/?search=phi
…lmap, r=jieyouxu Fix Pieter-Louis Schoeman mailmap entry I'm listed twice on thanks.rust-lang
rustbot
added
A-meta
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 1ae4f42 failed: CI. Failed job:
|
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[doc(alias = "phi")]for floatGOLDEN_RATIOconstants #156830 (Add#[doc(alias = "phi")]for floatGOLDEN_RATIOconstants)r? @ghost
Create a similar rollup