Implement argument-dependent target checking for the #[repr] parser#157215
Open
JonathanBrouwer wants to merge 5 commits into
Open
Implement argument-dependent target checking for the #[repr] parser#157215JonathanBrouwer wants to merge 5 commits into
#[repr] parser#157215JonathanBrouwer wants to merge 5 commits into
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
JonathanBrouwer
force-pushed
the
repr-target-checking3
branch
from
7758293 to
d58ea4a
Compare
Contributor
|
I like this approach of using ManuallyChecked and asserting whether it was! Good solution :3 |
mejrs
reviewed
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Ugh, #[repr] gives me a headache.
Anyway, the implementation looks good generally.
What is the plan going forward? I imagine a series of prs like:
- macrocall checking for the other attrs in #156499
- some kind of "this attribute does nothing even if this macro call expands into a valid target" note on the warning
- a PR to raise the lint level to deny by default for repr attrs on macro calls and do something about the
repr(simd)thing
|
|
||
| let attr_span = cx.attr_span; | ||
| cx.adcx().warn_empty_attribute(attr_span); | ||
|
|
Comment on lines
+143
to
+146
| cx.check_target( | ||
| "(simd)", | ||
| &AllowedTargets::AllowList(&[Allow(Target::Struct), Warn(Target::MacroCall)]), | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| cx.check_target( | |
| "(simd)", | |
| &AllowedTargets::AllowList(&[Allow(Target::Struct), Warn(Target::MacroCall)]), | |
| ); | |
| cx.check_target( | |
| "(simd)", | |
| &AllowedTargets::AllowList(&[ | |
| Allow(Target::Struct), // Feature gated in `rustc_ast_passes` | |
| Warn(Target::MacroCall), // FIXME: This is not feature gated (!!) | |
| ]), | |
| ); |
| @@ -1,8 +1,10 @@ | |||
| #### Note: this error code is no longer emitted by the compiler. | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Same with the other PR, please direct to the new error code.
| &AllowedTargets::AllowList(&[ | ||
| Allow(Target::Struct), | ||
| Allow(Target::Enum), | ||
| Allow(Target::Union), |
Contributor
There was a problem hiding this comment.
Suggested change
| Allow(Target::Union), | |
| Allow(Target::Union), // Feature gated in `rustc_hir_analysis` |
Comment on lines
+205
to
212
| if &*path.segments == [sym::repr] && attribute_args == "(align(...))" { | ||
| if matches!(target, Target::Fn | Target::Method(..)) { | ||
| diag.help("use `#[rustc_align(...)]` instead"); | ||
| } | ||
| if matches!(target, Target::Static) { | ||
| diag.help("use `#[rustc_align_static(...)]` instead"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Gate this on nightly build and/or rustc_attrs perhaps?
Comment on lines
+1208
to
1211
| let (reprs, _first_attr_span) = | ||
| find_attr!(attrs, Repr { reprs, first_span } => (reprs.as_slice(), Some(*first_span))) | ||
| .unwrap_or((&[], None)); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| let (reprs, _first_attr_span) = | |
| find_attr!(attrs, Repr { reprs, first_span } => (reprs.as_slice(), Some(*first_span))) | |
| .unwrap_or((&[], None)); | |
| let reprs = find_attr!(attrs, Repr { reprs, .. } => reprs.as_slice()).unwrap_or(&[]); |
Also do we still need to keep first_span in the AttributeKind::Repr?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some of #156499
Fixes some of #153101
Alternative approach to #156569, which was suggested in the comments here: #156569 (review)
How do you feel about this approach?
r? @mejrs