Move cross crate tests into the appropriate folder by danieljofficial · Pull Request #157447 · rust-lang/rust

danieljofficial · 2026-06-04T20:17:28Z

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of 133895

try-job: armhf-gnu

rustbot · 2026-06-04T20:17:31Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Kivooeo · 2026-06-05T01:00:01Z

cc @zedddie to avoid gsoc work conflicts

danieljofficial · 2026-06-05T08:26:12Z

cc @zedddie to avoid gsoc work conflicts

Noted.

jieyouxu

Thanks
@bors r+ rollup

View changes since this review

rust-bors · 2026-06-05T10:25:24Z

📌 Commit 2b55fda has been approved by jieyouxu

It is now in the queue for this repository.

@jieyouxu

…rate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](rust-lang#133895)

…uwer Rollup of 8 pull requests Successful merges: - #157467 (stdarch subtree update) - #156798 (delegation: do not always generate first argument) - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`) - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages) - #157447 (Move cross crate tests into the appropriate folder) - #157470 (Avoid ICE when emitting TargetMachine config errors) - #157474 (Forbid optimize(none) with inline(always) or inline.) - #157475 (Add a smoke test for the optimize attribute.)

JonathanBrouwer · 2026-06-05T13:24:53Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157481 (comment)

rust-bors · 2026-06-05T13:25:01Z

This pull request was unapproved.

This PR was contained in a rollup (#157481), which was unapproved.

View changes since this unapproval

danieljofficial · 2026-06-05T14:30:07Z

💔 I suspect this PR failed tests as part of a rollup @bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157481 (comment)

I can't tell what might've caused this, locally the tests are passing. So I'm a bit confused about what I should change to fix this.

Move cross crate tests into the appropriate folder try-job: armhf-gnu

jieyouxu · 2026-06-05T14:34:24Z

---- [ui] tests/ui/cross-crate/stable-symbol-hash-for-trait-object-projections.rs stdout ----

error: test did not exit with success! code=Some(127) so test would pass with `run-fail`
status: exit status: 127
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "1" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/auxiliary/libstable_symbol_hash_for_trait_object_projections.so"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/a", waiting for result
------------------------------------------
--- stderr -------------------------------
/tmp/work/test1271/a: error while loading shared libraries: libstable_symbol_hash_for_trait_object_projections.so: cannot open shared object file: No such file or directory
------------------------------------------

---- [ui] tests/ui/cross-crate/stable-symbol-hash-for-trait-object-projections.rs stdout end ----

Kivooeo · 2026-06-06T04:38:03Z

@bors r- because of conflict

rust-bors · 2026-06-06T04:38:05Z

This pull request was not previously approved.

jieyouxu · 2026-06-06T05:47:40Z

Ugh. Please rebase. I will bump the p on this PR.
@bors p=1 (conflict-prone)

rustbot · 2026-06-06T09:15:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jieyouxu · 2026-06-06T09:39:28Z

@bors r+

rust-bors · 2026-06-06T09:39:31Z

📌 Commit 1e1560b has been approved by jieyouxu

It is now in the queue for this repository.

rust-bors · 2026-06-06T11:01:57Z

⌛ Testing commit 1e1560b with merge 554b619...

Workflow: https://github.com/rust-lang/rust/actions/runs/27060515262

@jieyouxu

…youxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](#133895) try-job: armhf-gnu

JonathanBrouwer · 2026-06-06T16:08:11Z

Stuck
@bors yield

rust-bors · 2026-06-06T16:08:15Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27060515262

The next pull request likely to be tested is #157275.

JonathanBrouwer · 2026-06-06T16:10:33Z

@bors try jobs=dist-i686-msvc

rust-bors · 2026-06-06T16:10:39Z

⌛ Trying commit 1e1560b with merge 5139e1f…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/27067249364

Move cross crate tests into the appropriate folder try-job: dist-i686-msvc

rust-bors · 2026-06-06T19:31:28Z

⌛ Testing commit 1e1560b with merge e97a4f2...

Workflow: https://github.com/rust-lang/rust/actions/runs/27071779922

@jieyouxu

…youxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](#133895) try-job: armhf-gnu

JonathanBrouwer · 2026-06-06T19:33:28Z

@bors yield

rust-bors · 2026-06-06T19:33:31Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27071779922

The next pull request likely to be tested is #157541.

JonathanBrouwer · 2026-06-06T19:35:49Z

Try job got stuck two times in a row now.
Gonna give it one more try to see if it is spurious, but unapproving for now
@bors r-
@bors try cancel
@bors try jobs=dist-i686-msvc

rust-bors · 2026-06-06T19:35:52Z

View changes since this unapproval

rust-bors · 2026-06-06T19:35:54Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27067249364

rust-bors · 2026-06-06T19:35:57Z

⌛ Trying commit 1e1560b with merge 30ae555…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/27071878505

Move cross crate tests into the appropriate folder try-job: dist-i686-msvc

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2026

rustbot assigned jieyouxu Jun 4, 2026

jieyouxu approved these changes Jun 5, 2026

View reviewed changes

Comment thread tests/ui/issues/issue-2170-exe.rs

Comment thread tests/ui/cross-crate/mut-ref-write-visible-after-unwind.rs Outdated

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026

This was referenced Jun 5, 2026

tests/ui/issues/issue-2170-exe.rs is ineffective #157477

Open

tests/ui/issues/issue-29485.rs has a useless #[feature(recover)] #157478

Closed

JonathanBrouwer mentioned this pull request Jun 5, 2026

Rollup of 8 pull requests #157481

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2026

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 5, 2026

Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=<try>

4c58f6e

Move cross crate tests into the appropriate folder try-job: armhf-gnu

danieljofficial force-pushed the move-tests-cross-crate branch from 2b55fda to dc17feb Compare June 5, 2026 15:11

This comment was marked as outdated.

Sign in to view

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2026

This comment was marked as outdated.

Sign in to view

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 5, 2026

danieljofficial added 2 commits June 6, 2026 09:31

move cross crate tests out of ui/issues

17ebb8f

add issue links and bless

1e1560b

danieljofficial force-pushed the move-tests-cross-crate branch from dc17feb to 1e1560b Compare June 6, 2026 09:15

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2026

rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026

Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=<try>

5139e1f

Move cross crate tests into the appropriate folder try-job: dist-i686-msvc

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2026

rust-bors Bot pushed a commit that referenced this pull request Jun 6, 2026

Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=<try>

30ae555

Move cross crate tests into the appropriate folder try-job: dist-i686-msvc

Uh oh!

Conversation

danieljofficial commented Jun 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 4, 2026

Uh oh!

Kivooeo commented Jun 5, 2026

Uh oh!

danieljofficial commented Jun 5, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rust-bors Bot commented Jun 5, 2026

Uh oh!

JonathanBrouwer commented Jun 5, 2026

Uh oh!

rust-bors Bot commented Jun 5, 2026

Uh oh!

danieljofficial commented Jun 5, 2026

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

jieyouxu commented Jun 5, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Kivooeo commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026

Uh oh!

jieyouxu commented Jun 6, 2026

Uh oh!

rustbot commented Jun 6, 2026

Uh oh!

jieyouxu commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026

Uh oh!

JonathanBrouwer commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026

Uh oh!

JonathanBrouwer commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026

Uh oh!

rust-bors Bot commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

danieljofficial commented Jun 4, 2026 •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

rust-bors Bot commented Jun 6, 2026 •

edited

Loading

rust-bors Bot commented Jun 6, 2026 •

edited

Loading

rust-bors Bot commented Jun 6, 2026 •

edited

Loading

rust-bors Bot commented Jun 6, 2026 •

edited

Loading