mark `Encode`, `Decode`, `Mark` impls as `#[inline]` by cyrgani · Pull Request #157450 · rust-lang/rust

cyrgani · 2026-06-04T20:44:11Z

Related to #157271 (though it was not a part of it). This looked pretty promising locally.

Kobzol · 2026-06-04T21:19:33Z

[PERF] `#[inline]` `Encode`, `Decode`, `Mark`

rust-bors · 2026-06-04T23:29:17Z

☀️ Try build successful (CI)
Build commit: c573dee (c573dee1ed874df7432921919f59a3223306766f, parent: 688ab44c7439a226d792990f81cd8df0603747d8)

rust-timer · 2026-06-05T00:12:38Z

Finished benchmarking commit (c573dee): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.7%, -0.3%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.5%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.9%, 4.5%]	4
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-2.9%	[-3.5%, -2.3%]	2
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	0.5%	[-3.5%, 4.5%]	6

Cycles

Results (secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-4.6%, -2.6%]	4
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Bootstrap: 515.112s -> 516.189s (0.21%)
Artifact size: 400.60 MiB -> 400.64 MiB (0.01%)

cyrgani · 2026-06-05T07:26:20Z

Looking at the non-significant results also shows much more green than red, so this is really a small improvement.

rustbot · 2026-06-05T07:26:28Z

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @petrochenkov

petrochenkov · 2026-06-05T09:57:19Z

@bors r+ rollup=maybe

rust-bors · 2026-06-05T09:57:21Z

📌 Commit fb79578 has been approved by petrochenkov

It is now in the queue for this repository.

mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.

…uwer Rollup of 8 pull requests Successful merges: - #157467 (stdarch subtree update) - #156798 (delegation: do not always generate first argument) - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`) - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages) - #157447 (Move cross crate tests into the appropriate folder) - #157470 (Avoid ICE when emitting TargetMachine config errors) - #157474 (Forbid optimize(none) with inline(always) or inline.) - #157475 (Add a smoke test for the optimize attribute.)

mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.

…uwer Rollup of 12 pull requests Successful merges: - #157467 (stdarch subtree update) - #155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets) - #156798 (delegation: do not always generate first argument) - #157016 (add `extern "tail"` calling convention) - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`) - #148183 (rustdoc: Test & document `test_harness` code block attribute) - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages) - #157470 (Avoid ICE when emitting TargetMachine config errors) - #157474 (Forbid optimize(none) with inline(always) or inline.) - #157475 (Add a smoke test for the optimize attribute.) - #157479 (Warn when `#[macro_use]` or `#[macro_escape]` is used on the crate root) - #157486 (Remove unused attributes from issue-29485.rs.) Failed merges: - #157485 (Rename `errors.rs` file to `diagnostics.rs`)

mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.

@aapoalas

Rollup of 12 pull requests Successful merges: - #155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets) - #156798 (delegation: do not always generate first argument) - #157438 (rustdoc: don't link doc(hidden) associated type projections) - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`) - #148183 (rustdoc: Test & document `test_harness` code block attribute) - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages) - #157396 (Add @aapoalas to libs review rotation) - #157470 (Avoid ICE when emitting TargetMachine config errors) - #157474 (Forbid optimize(none) with inline(always) or inline.) - #157475 (Add a smoke test for the optimize attribute.) - #157479 (Warn when `#[macro_use]` or `#[macro_escape]` is used on the crate root) - #157486 (Remove unused attributes from issue-29485.rs.) Failed merges: - #157485 (Rename `errors.rs` file to `diagnostics.rs`)

@aapoalas

Rollup of 12 pull requests Successful merges: - #157467 (stdarch subtree update) - #155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets) - #156798 (delegation: do not always generate first argument) - #157438 (rustdoc: don't link doc(hidden) associated type projections) - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`) - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages) - #157396 (Add @aapoalas to libs review rotation) - #157470 (Avoid ICE when emitting TargetMachine config errors) - #157474 (Forbid optimize(none) with inline(always) or inline.) - #157475 (Add a smoke test for the optimize attribute.) - #157479 (Warn when `#[macro_use]` or `#[macro_escape]` is used on the crate root) - #157486 (Remove unused attributes from issue-29485.rs.) Failed merges: - #157485 (Rename `errors.rs` file to `diagnostics.rs`)

mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.

Rollup merge of #157450 - cyrgani:pm-inline, r=petrochenkov mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to #157271 (though it was not a part of it). This looked pretty promising locally.

cyrgani added 2 commits June 3, 2026 20:27

#[inline] for Encode and Decode

1fcc953

#[inline] for Mark

fb79578

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 4, 2026

cyrgani mentioned this pull request Jun 4, 2026

[PERF] directly manage Buffer memory without using Vec #157451

Draft

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 4, 2026

Auto merge of #157450 - cyrgani:pm-inline, r=<try>

c573dee

[PERF] `#[inline]` `Encode`, `Decode`, `Mark`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 5, 2026

cyrgani marked this pull request as ready for review June 5, 2026 07:26

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2026

rustbot assigned petrochenkov Jun 5, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 5, 2026

cyrgani changed the title ~~[PERF] #[inline] Encode, Decode, Mark~~ mark Encode, Decode, Mark impls as #[inline] Jun 5, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026

JonathanBrouwer mentioned this pull request Jun 5, 2026

Rollup of 8 pull requests #157481

Closed

JonathanBrouwer mentioned this pull request Jun 5, 2026

Rollup of 10 pull requests #157484

Closed

JonathanBrouwer mentioned this pull request Jun 5, 2026

Rollup of 12 pull requests #157492

Closed

jhpratt mentioned this pull request Jun 5, 2026

Rollup of 12 pull requests #157502

Closed

jhpratt mentioned this pull request Jun 5, 2026

Rollup of 12 pull requests #157504

Merged

GuillaumeGomez mentioned this pull request Jun 5, 2026

Rollup of 11 pull requests #157505

Closed

rust-bors Bot merged commit 5fba2b7 into rust-lang:main Jun 5, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

mark `Encode`, `Decode`, `Mark` impls as `#[inline]`#157450

mark `Encode`, `Decode`, `Mark` impls as `#[inline]`#157450
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
cyrgani:pm-inline

cyrgani commented Jun 4, 2026

Uh oh!

Kobzol commented Jun 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 5, 2026

Uh oh!

cyrgani commented Jun 5, 2026

Uh oh!

rustbot commented Jun 5, 2026

Uh oh!

petrochenkov commented Jun 5, 2026

Uh oh!

rust-bors Bot commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

cyrgani commented Jun 4, 2026

Uh oh!

Kobzol commented Jun 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 5, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

cyrgani commented Jun 5, 2026

Uh oh!

rustbot commented Jun 5, 2026

Uh oh!

petrochenkov commented Jun 5, 2026

Uh oh!

rust-bors Bot commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants