Move rwviewer into rwgame with imgui#719
Open
danhedron wants to merge 4 commits intorwengine:mainfrom
Open
Conversation
ghost
reviewed
May 27, 2019
ghost
reviewed
May 27, 2019
rwgame/RWViewer.cpp
Outdated
| std::transform(filename.begin(), filename.end(), filename.begin(), | ||
| ::tolower); | ||
| if (!filename.compare("text")) { | ||
| textPath = p; |
ghost
reviewed
May 27, 2019
rwgame/RWViewer.cpp
Outdated
| throw std::runtime_error("text directory not found in gamedata path"); | ||
| } | ||
| std::vector<std::string> names; | ||
| for (const rwfs::path& p : rwfs::directory_iterator(textPath)) { |
ghost
reviewed
May 27, 2019
rwgame/RWViewer.cpp
Outdated
| auto langName = p.filename().string(); | ||
| std::transform(langName.begin(), langName.end(), langName.begin(), | ||
| ::tolower); | ||
| names.push_back(langName); |
ghost
reviewed
May 27, 2019
ghost
reviewed
May 27, 2019
ghost
reviewed
May 27, 2019
ghost
reviewed
May 27, 2019
ghost
reviewed
May 27, 2019
ghost
reviewed
May 27, 2019
rwgame/RWViewer.cpp
Outdated
| if (ImGui::Selectable(it->second.second.c_str(), false, | ||
| ImGuiSelectableFlags_AllowDoubleClick)) { | ||
| if (ImGui::IsMouseDoubleClicked(0)) { | ||
| strncpy(previewStr_, it->second.second.c_str(), 512); |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 18.12% 18.72% +0.59%
==========================================
Files 252 229 -23
Lines 22938 22211 -727
Branches 5769 5795 +26
==========================================
Hits 4158 4158
+ Misses 17659 16935 -724
+ Partials 1121 1118 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danhedron
force-pushed
the
ingame-viewer
branch
2 times, most recently
from
ec695f5 to
76fa233
Compare
danhedron
force-pushed
the
ingame-viewer
branch
2 times, most recently
from
36faf5a to
3950d8c
Compare
danhedron
force-pushed
the
ingame-viewer
branch
from
3950d8c to
2247757
Compare
Access with `--viewer`, this replaces the Qt based tool
danhedron
force-pushed
the
ingame-viewer
branch
from
2247757 to
69afb86
Compare
Lihis
approved these changes
Oct 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a lot of stuff that's needed just for Qt and simplifies the code.
A few things left to match functionality with rwviewer
Free-cam map viewer
Make it possible to remove viewed objects