Repository navigation
style(tables): bring roomier Rich-like table styling to main - #69
Merged
Merged
Conversation
Reviewer's GuideUIUpdate the default Markdown table styling with roomier cell padding, accent-colored headers, a neutral header separator, and symmetric first-row spacing while preserving the terminal-style opt-out.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="web/src/styles/global.css" line_range="3075" />
<code_context>
padding-top: 0 !important;
}
- /* Default table style: simple 1px borders on every cell, no webtui pseudo
</code_context>
<issue_to_address>
**Slide tables become much taller**
When a slide contains a dense Markdown table, the default-table rule also adds `0.4lh` above and below every cell in presentation tables. Dense slides therefore need substantially more vertical space and their content becomes scrollable instead of fitting in the slide.
Scope the roomier cell padding to non-presentation tables, or preserve the compact padding for tables inside presentations.
</issue_to_address>
### Comment 2
<location path="web/src/styles/global.css" line_range="3123" />
<code_context>
> tr:first-child
> :is(td, th) {
- padding-top: 0 !important;
+ padding-top: 0.4lh !important;
}
</code_context>
<issue_to_address>
**Code previews gain a top gap**
When a CodePreview table contains `.line-code` cells, the new first-row `padding-top: 0.4lh !important` rule overrides the existing `table:has(.line-code)` zero-padding reset, leaving a gap above the first code line while later lines remain tight.
Restrict the first-row padding rule to terminal tables so CodePreview tables retain zero padding.
Also at `web/src/styles/global.css:3124`.
</issue_to_address>| border: 1px solid var(--foreground3); | ||
| padding: 0 1ch; | ||
| padding: 0.4lh 1.25ch; | ||
| } |
There was a problem hiding this comment.
🟡 Medium · Slide tables become much taller
When a slide contains a dense Markdown table, the default-table rule also adds 0.4lh above and below every cell in presentation tables. Dense slides therefore need substantially more vertical space and their content becomes scrollable instead of fitting in the slide.
Scope the roomier cell padding to non-presentation tables, or preserve the compact padding for tables inside presentations.
Prompt for AI agents
In `web/src/styles/global.css` at line 3075:
**Slide tables become much taller**
When a slide contains a dense Markdown table, the default-table rule also adds `0.4lh` above and below every cell in presentation tables. Dense slides therefore need substantially more vertical space and their content becomes scrollable instead of fitting in the slide.
Scope the roomier cell padding to non-presentation tables, or preserve the compact padding for tables inside presentations.
| > tr:first-child | ||
| > :is(td, th) { | ||
| padding-top: 0 !important; | ||
| padding-top: 0.4lh !important; |
There was a problem hiding this comment.
🟡 Medium · Code previews gain a top gap
When a CodePreview table contains .line-code cells, the new first-row padding-top: 0.4lh !important rule overrides the existing table:has(.line-code) zero-padding reset, leaving a gap above the first code line while later lines remain tight.
Restrict the first-row padding rule to terminal tables so CodePreview tables retain zero padding.
Also at web/src/styles/global.css:3124.
Prompt for AI agents
In `web/src/styles/global.css` at line 3123:
**Code previews gain a top gap**
When a CodePreview table contains `.line-code` cells, the new first-row `padding-top: 0.4lh !important` rule overrides the existing `table:has(.line-code)` zero-padding reset, leaving a gap above the first code line while later lines remain tight.
Restrict the first-row padding rule to terminal tables so CodePreview tables retain zero padding.
Also at `web/src/styles/global.css:3124`.
Deploying sam-onl with
|
| Latest commit: |
326c334
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a9b309a.sam-onl.pages.dev |
| Branch Preview URL: | https://fix-rich-markdown-table-spac.sam-onl.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the roomier square-grid Markdown table styling that was visible only in the local checkout: 0.4lh vertical cell padding, accent-colored headers, and a neutral header separator. All table text continues to inherit 1rem.
Summary by Sourcery
Enhancements: