Skip to content

feat(tui): extend terminal reading experience - #70

Open
saforem2 wants to merge 41 commits into
mainfrom
feat/tui-terminal-reading-experience
Open

saforem2 wants to merge 41 commits into
mainfrom
feat/tui-terminal-reading-experience

Conversation

@saforem2

@saforem2 saforem2 commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Extend the TUI styling for tables, lists, code blocks, and navigation.
  • Add a standalone reading-style comparison page and examples for ezpz submit, ezpz status, and ezpz fetch.
  • Render Mermaid diagrams with Pele and add Stylelint to the root lint command.
  • Add RD3 research, platform, appointment, service, training, and recognition details to the About page.

Verification

  • bun run lint
  • bun run build
  • Browser-checked the About page, flowcharts, and Gantt diagrams.

Summary by Sourcery

Extend the terminal-inspired reading experience with richer content styling, safer interactive diagrams, updated HPC command examples, and expanded professional content.

New Features:

  • Add a richer terminal-style presentation for job status output, including detailed notes, node mappings, warnings, and execution timing.
  • Add Iosevka25 Condensed font support and a standalone TUI content styling layer for structured reading.
  • Render Mermaid diagrams through Pele with interactive resizing, theme integration, and sanitized SVG output.
  • Expand the About page with RD3 research, appointments, service, training, recognition, publications, and project information.
  • Add video links to talks and document ezpz submit, status, and fetch workflows with updated examples.

Bug Fixes:

  • Improve heading context behavior, list alignment, table scrolling, sticky columns, code-block sizing, and diagram layout across responsive views.
  • Correct profile styling and refine diagram and table rendering behavior after replacing the Mermaid integration.

Enhancements:

  • Refine terminal-inspired typography, tables, lists, blockquotes, code blocks, navigation guides, definition lists, and structured-content widths for readability.

Build:

  • Replace Mermaid dependencies with Pele and add Stylelint configuration and CSS linting to the root lint command.

Documentation:

  • Update the benchmark article and talks pages with clearer results, reproduction guidance, and direct video references.
  • Refresh WebTUI navigation and remove outdated HTML-to-slides guidance.

Chores:

  • Add self-hosted Iosevka25 Condensed font assets and licensing information.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 14:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@sourcery-ai

sourcery-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Sorry @saforem2, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days and 6 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying sam-onl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 46b174f
Status: ✅  Deploy successful!
Preview URL: https://e628ab54.sam-onl.pages.dev
Branch Preview URL: https://feat-tui-terminal-reading-ex.sam-onl.pages.dev

View logs

@sourcery-ai

sourcery-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Schema and migrations

Add optional validated video URLs to the content collection so talk pages can provide recording links.

  • web/src/content.config.ts L19

Implementation

Replace Mermaid rendering with Pele, including safe SVG parsing, theme propagation, viewport handling, and rerender scheduling.

  • web/src/utils/mermaid-render.ts L14-135, L184-215, L637-744 (+5 small edits)

UI

Extend rich status and table components with structured status details, improved scrolling, and host and job-state styling.

  • web/src/components/RichStatusDetails.astro L1-115
  • web/src/components/RichTable.astro L63-106, L155-170, L177-183 (+7 small edits)

Expose the condensed Iosevka font in the site and slide font selectors and load its self-hosted font faces.

  • web/public/fonts/iosevka25-condensed/OFL.txt L1-92
  • web/public/fonts/iosevka25-condensed/iosevka25-condensed.css L1-48
  • web/src/components/Filter.astro L61, L70, L82
  • web/src/components/slides/SlideHelpDialog.astro L26, L41
  • web/src/layouts/Layout.astro L61
  • web/public/fonts/iosevka25-condensed/Iosevka25Condensed-Bold.woff2
  • web/public/fonts/iosevka25-condensed/Iosevka25Condensed-BoldItalic.woff2
  • web/public/fonts/iosevka25-condensed/Iosevka25Condensed-Italic.woff2
  • web/public/fonts/iosevka25-condensed/Iosevka25Condensed-Regular.woff2

Apply the terminal reading styles across article lists, definition lists, tables, code, blockquotes, and navigation, including sticky table columns and structured-content sizing.

  • web/src/layouts/Doc.css L750-759, L989-1028, L1421-1443 (+11 small edits)
  • web/src/pages/css/profile.css L252
  • web/src/styles/global.css L781-792, L3010-3020, L3189-3250 (+30 small edits)
  • web/src/styles/tui-content.css L1-51
  • web/src/styles/themes/pytorch.css L114 (removed lines)

Update layout-level diagram sizing and remove Mermaid-specific modal and normalization rules now that rendering is handled by Pele.

  • web/src/layouts/Layout.astro L397-589 (4 small edits)

Make the pinned heading context appear only after its source heading scrolls out of the article viewport.

  • web/src/layouts/Doc.astro L425, L1734-1744

Add the standalone reading-style comparison lab and extend the WebTUI landing page navigation.

  • web/src/pages/webtui/index.mdx L9-13

Configuration

Add Stylelint and wire CSS linting into the root lint command while removing Mermaid dependencies and adding Pele.

  • .stylelintrc.json L1-36
  • package.json L10-58 (4 small edits)
  • web/package.json L33, L36 (removed lines)

Remove the obsolete Mermaid bundling workaround and tidy the configured Vite host list.

  • web/astro.config.mjs L564-570 (+3 small edits)

Documentation

Document the remote and local submit-status-fetch workflow and show a richer static status table with notes, node mappings, and endpoint warnings.

  • web/src/pages/posts/2026/10/16/index.mdx L177-200, L215-277 (+2 small edits)

Revise the benchmark report to clarify measured results, system differences, run phases, queued jobs, and reproduction steps.

  • web/src/pages/posts/2026/11/11/index.mdx L65-68, L134-145 (+7 small edits)

Expand the About page with the new research and ezpz accomplishments, talk video links, and updated project, career, service, awards, and event details while adopting the default table styling.

  • web/src/pages/about/index.mdx L913-942, L948-966, L1652-1673 (+16 small edits)

Add the recording URL to the PyTorch talk page and remove the talks-list HTML-to-slides tip.

  • web/src/pages/talks/2026/10/21/index.mdx L8
  • web/src/pages/talks/index.mdx L41 (removed lines)

Lock files and vendored code

Refresh the Bun lockfile to record the dependency and tooling changes.

  • bun.lock L204-220, L1840-1843 (+90 small edits)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

Comment thread web/src/utils/mermaid-render.ts Resolved
Comment thread web/src/utils/mermaid-render.ts Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants