Get some more information from a video#11
Open
memento wants to merge 14 commits intosapher:masterfrom
Open
Conversation
… like_count, dislike_count, repost_count, average_rating and more. Also updated the test class YoutubeDLTest.java accordingly.
Added the way to import the project dependency into a maven project
Corrected version 1.1 to 1.+ To import, check what's in the <version> tag here https://github.com/sapher/youtubedl-java/blob/master/pom.xml
I forgot to increment version ;)
Author
|
I forgot to update version in pull request. Now, done. |
Here, proxychains is mandatory
Though, we still need to use YoutubeDL after an initialization, not in a static way like when not using proxychains. (TODO)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I needed to be able to get some more informations from a video.
Example :
I added the fields in the mapping class, also some getters and I updated a test class accordingly.
I also updated you README.md with the Maven way of importing your project.
Maybe you'll find that interresting enough to merge.
Regards and thanks for your work.