Feature/event subprocess#475
Merged
Merged
Conversation
Contributor
Author
|
Also, this adds support for event subprocesses, the ultimate reason for the work, but which I forgot to mention originally. |
Contributor
Author
|
Merging this so OneFM can start using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the waiting task index with something simpler that relies on existing task spec methods to maintain a list of waiting tasks. It also allows for the creation of subworkflows to be created outside the normal flow. This makes it easier to handle collaborations (the existing solution was a terrible hack that I've long been ashamed of) as well as spawning event subprocesses that do not have parents in the regular flow. Taken together, these changes are one more step towards being able to execute a collection or related processes in a way that keeps them distinct from each other.
I've also deprecated
refresh_waiting_tasksin favor ofrefresh_timers, since (1) I want to ultimately get rid of callback methods passed to workflow methods (they're duplicative of more flexible task spec methods) and (2) the only tasks that need to be refreshed are timers, as other events will be updated when events are caught.The other potentially useful addition is a
bpmn_start_eventattribute on workflow specs. This made disconnected workflows a lot easier to create, but could be potentially useful to library users so I want to flag it; it is probably an easier way to know how a process can start than the parser provides.