Repository navigation
ui: add dismissible What's New announcement banner and modal - #665
Merged
Merged
Conversation
Sashiko reviewCommit 1/1 —
|
In the global keydown listener in static/index.html, keyboard navigation shortcuts (such as /, j, k, Enter, and q) previously only checked whether an input or textarea element had focus. Pressing navigation keys while an overlay modal (such as the About, Settings, or Sign In modal) was open, or after an interactive element already called preventDefault on the key event, still triggered background list navigation and row activation behind the modal. Abort the global navigation keydown handler when e.defaultPrevented is true or when any .modal-overlay.open element is present so keyboard events do not leak into background view navigation while a modal is active. Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
Add a top-level Whats New banner and announcement modal to the web UI configured via the WHATS_NEW constant at the top of the script section in static/index.html. When WHATS_NEW.headline or WHATS_NEW.body is populated, the banner renders at the top of the page above the application header with a Whats New badge and headline. Clicking the banner opens a modal displaying the full announcement and records a digest of the announcement in localStorage so the banner stays hidden across page loads until the announcement is updated. A close button on the banner also allows dismissing it directly without opening the modal. By default WHATS_NEW is left empty with a commented example so the banner remains hidden until populated. Because auth-header is absolutely positioned outside the re-rendered app container and previously used body-relative coordinates (top: 32px; right: 16px) that assumed app was at the top of body, wrap auth-header and app in a relative app-shell container (with top: 20px; right: 0 accounting for body padding) so auth-header shifts down together with the application header when the Whats New banner is visible above it. Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
rgushchin
force-pushed
the
feat/whats-new-banner
branch
from
October 9, 2026 11:53
4bc55d7 to
5b3db59
Compare
Member
Author
|
Addressed in the updated branch:
|
Sashiko review — v2Commit 1/2 —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a top-level What's New announcement banner and modal to the web UI (
static/index.html) for periodic manual announcements:WHATS_NEWconstant at the top of the<script>section instatic/index.html({ id, date, headline, body }), left empty by default with a commented example.headlineorbodyis populated, a compact banner appears at the top of the page. Clicking the banner opens a modal with the full announcement and stores a digest of the announcement inlocalStorage(sashiko_whats_new_dismissed) so the banner stays hidden across future visits untilid,headline, orbodyis changed.×close button on the banner to dismiss without opening the modal.