Skip to content

mem(leak): _fbird_drop_table orphans fbird_transaction struct after clearing default-tx node #575

Description

@satwareAG-ironMike

Found during #554 Phase B review (PR #574) - pre-existing, not introduced there.

Problem

In _fbird_drop_table (fbird_inspection.c ~line 230): when the default transaction's node is cleared ((*l)->trans = NULL so the slot can be reused), the underlying fbird_transaction struct itself is never efreed. The struct leaks.

Source

Positional-era behavior carried over into the flag-based code; the commit path (_php_fbird_commit_link) efrees the default tx, but the drop_table early-commit path only clears the pointer.

Acceptance

  • Default tx committed via _fbird_drop_table: struct efree'd, slot reusable
  • ASAN/valgrind clean on a repro PHPT

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions