Skip to content

(BSR) Add claude code review for runner-manager#713

Merged
matthiasL-scality merged 1 commit intomainfrom
bsr-add-claude-code-review
Apr 13, 2026
Merged

(BSR) Add claude code review for runner-manager#713
matthiasL-scality merged 1 commit intomainfrom
bsr-add-claude-code-review

Conversation

@matthiasL-scality
Copy link
Copy Markdown
Contributor

This pull request introduces automated code review capabilities for the runner-manager project using Claude and GitHub Actions. It adds a reusable workflow to trigger reviews on pull requests, configures the Claude plugin environment, and documents the review process and project structure. The most important changes are grouped below:

Automated code review workflow:

  • Adds a new GitHub Actions workflow (.github/workflows/review.yml) that triggers on pull requests and delegates the review job to a shared workflow, passing required cloud and Anthropic credentials as secrets.

Claude plugin and skill configuration:

  • Enables the scality-skills@scality-agent-hub plugin in the Claude settings (.claude/settings.json).
  • Introduces a new review-pr skill (.claude/skills/review-pr/SKILL.md) that defines how Claude reviews pull requests, including criteria for code quality, error handling, type hints, security, and more. The skill supports both CI (automated) and local (manual) review modes, and details the expected review output format.

Project documentation:

  • Adds a CLAUDE.md file describing the purpose, architecture, and directory structure of the runner-manager service, as well as its technology stack and integration points.

@matthiasL-scality matthiasL-scality requested a review from a team as a code owner April 10, 2026 13:51
@matthiasL-scality matthiasL-scality force-pushed the bsr-add-claude-code-review branch from ef009c5 to 50ccbc5 Compare April 13, 2026 08:43
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.79%. Comparing base (b635b01) to head (9970ea3).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files          36       36           
  Lines        1809     1809           
=======================================
  Hits         1552     1552           
  Misses        257      257           
Flag Coverage Δ
api 56.77% <ø> (ø)
unit 70.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 13, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@matthiasL-scality matthiasL-scality force-pushed the bsr-add-claude-code-review branch from 11230f4 to 9970ea3 Compare April 13, 2026 09:24
@matthiasL-scality matthiasL-scality merged commit 626dd09 into main Apr 13, 2026
21 checks passed
@matthiasL-scality matthiasL-scality deleted the bsr-add-claude-code-review branch April 13, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants