feat: Add floating keyboard functionality to Scribe-Android (#261)#621
Open
prince-0408 wants to merge 4 commits into
Open
feat: Add floating keyboard functionality to Scribe-Android (#261)#621prince-0408 wants to merge 4 commits into
prince-0408 wants to merge 4 commits into
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
… prevent keyboard cutting off on right in floating mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements and refines the floating keyboard functionality for Scribe-Android. It introduces a movable, resizable, and floating keyboard layout, and resolves various styling issues across both light and dark modes.
Adding this feature solves a major point of confusion during onboarding/development where developers couldn't locate the keyboard in emulators that default to a floating state. It also greatly improves the keyboard experience in full-screen games, split-screen multitasking, and landscape layouts on tablet/phone screens.
Closes #261
Changes Made
floating_drag_barwith visibility state tied to the floating preference.floating_drag_handlepill.resize_handle_top_left/rightandresize_handle_bottom_left/right).5dp) and wider (64dpcanvas) rounded capsule.32dp) to comfortably display the updated handle.resize_handle_colorfor both modes (#FF555555solid medium-dark grey in light mode, and#FFB0B0B0solid medium-light grey in dark mode).keyboard_cardto dynamically update its background color based on the current theme (dark_keyboard_bg_colororlight_keyboard_bg_color) instead of using a static light grey.Screenshots