invalid-parameter-default fix#685
Conversation
Thank you for the pull request! 💙🩵The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
hi @andrewtavis , I guess checks are failing since I missed downgrading 'not-iterable' ty errors to 'warn' in my previous migration-related PR, it is getting flagged in the checks by default, could you please have a look? |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Work was really good here, @ashb155 :) I reverted the changes though as I had so many things that needed to be merged in from #666 that it made sense to start from scratch. This PR will actually close the epic now as well as I needed to turn on all of the ty checks to make sure that #666 was being done appropriately 😊
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
Fixed
invalid-parameter-defaultwarnings by updating for optional parameters across 9 files:cli/contracts/filter.pycli/convert.pycli/get.pycli/list.pycli/total.pyunicode/generate_emoji_keywords.pywikidata/parse_dump.pywikidata/query_data.pywikidata/wikidata_utils.pyVerified with
uvx ty check— no remaininginvalid-parameter-defaultwarnings.Related issue