initial draft of adding buddypress support

[clariner]

i have created the required files to support buddpress groups. I think the only thing remaining that i would need some pointers with is the converting the the posts 2 posts query arguments to one supported by BP_Groups_Group::get()

[scribu]

P2P already has a bin/install-wp-tests.sh file, so this file is a duplicate and should be removed.

[scribu]

After only a quick look, the code looks alright. I will do some actual testing when you say it's ready.

Due to #449, in order to be able to merge this, you will have to submit all the files from the core/ directory in a separate pull request to https://github.com/scribu/wp-lib-posts-to-posts.

[clariner]

I will double check but I had issues with using an version above V1.6.3.

AFAIK it was down to missing files / unable to file certain files. I will merge in #449 to my version and review.

If I find anything I will posts on #449

[scribu]

AFAIK it was down to missing files / unable to file certain files.

You need to install the Composer dependencies. See the updated CONTRIBUTING.md.

[clariner]

I will be able to issue a complete pull request against the other repository once i have resolved the final issue which is how to modify the do_query, capture_query and get_list functions.

As WP_Query and WP_User_Query can't be used is it possible to convert these function to use $wpdb? It doesn't seem like $wpdb->get_results() is available ($wpdb is null, i have use global) within these functions.
If they can be modified how can the arguments be passed along?

[scribu]

As WP_Query and WP_User_Query can't be used is it possible to convert these function to use $wpdb?

If BuddyPress doesn't have an equivalent class, like BP_Group_Query, then yeah, using $wpdb is fine.

($wpdb is null, i have use global)

That's not possible, since WordPress can't load plugins without having first set up $wpdb.

[scribu]

If they can be modified how can the arguments be passed along?

If there is no BP_Group_Query class to hook into, you will still be able to use p2p_type( 'some_connection_type' )->get_connected( $some_group ).

[clariner]

It looks like BP_Group_Query and BP_User_Query will be available in Buddypress 2.2.

[clariner]

I have update the pull request to support changes in #449.

[scribu]

Cool, but if you look at the changed files you'll see that there are 4 that need to be deleted from this PR:

• bin/install-wp-tests
• core/item-bpgroup.php
• core/query-bpgroup.php
• core/side-bpgroup.php

[clariner]

I have updated the pull request following your comments.

[solhuebner]

BuddyPress support is a great addition!
Thank you!

[solhuebner]

Any news for this?