fix: use regexp to extract pytorch version in misc.py#281
Open
soulteary wants to merge 2 commits intosczhou:masterfrom
Open
fix: use regexp to extract pytorch version in misc.py#281soulteary wants to merge 2 commits intosczhou:masterfrom
soulteary wants to merge 2 commits intosczhou:masterfrom
Conversation
|
hi! This commit wont catch pytorch installs with rocm, such as 1.13.1+rocm5.2. Maybe shouldn´t we remove $ at the end of regex? This will it will catch 1.13.1 and ignore +rocm5.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sczhou , I've test above version, all cases are passed:
online review link: https://regex101.com/r/pfxFFI/1
ref: #148 #279 #280