Update HttpClient tests to use httpbingo.org instead of httpbin.seatsio.net#151
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the HttpClient integration-style tests to use the public httpbingo.org service instead of the previously seatsio-hosted httpbin.seatsio.net, keeping the tests’ expected exception messages in sync with the new base URL.
Changes:
- Switched ExponentialBackoff tests to target
https://httpbingo.organd updated asserted error messages accordingly. - Switched the timeout/error-handling test to target
https://httpbingo.organd updated the asserted error message accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/testExponentialBackoff.py | Repoints backoff/retry tests to httpbingo and updates expected URLs in exception messages. |
| tests/testErrorHandling.py | Repoints timeout test to httpbingo and updates expected URL in exception message. |
Comments suppressed due to low confidence (1)
tests/testExponentialBackoff.py:71
- The last test uses a nonstandard /status/429:0.25,204:0.75 endpoint (weighted/random status codes). This looks specific to the previous seatsio-hosted httpbin instance and may not be supported by httpbingo.org, which would make this test fail or become flaky. Consider replacing this with a deterministic local stub server (first N requests => 429, then 204) or another httpbingo-supported endpoint that reliably returns a 429 followed by success.
client = HttpClient("https://httpbingo.org", "aSecretKey", None, 5)
i = 0
while i < 20:
client.url("/status/429:0.25,204:0.75").post()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.