Skip to content

fix(giga): match panic recovery to v2#3045

Open
arajasek wants to merge 2 commits intoasr/fee-validation-noncefrom
asr/giga-misc-fixes
Open

fix(giga): match panic recovery to v2#3045
arajasek wants to merge 2 commits intoasr/fee-validation-noncefrom
asr/giga-misc-fixes

Conversation

@arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 10, 2026

Describe your changes and provide context

  • Seq mode needs to trap panics
  • OCC mode needs to lower panics to the appropriate error code: ErrOCCAbort, ErrOutOfGas, or ErrPanic

Testing performed to validate your change

tests pass

@arajasek arajasek changed the title fix(giga) fix(giga): match panic recovery to v2 Mar 10, 2026
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 12, 2026, 1:30 PM

@arajasek arajasek marked this pull request as draft March 10, 2026 13:15
@arajasek
Copy link
Contributor Author

Draft until confirmed it syncs mainnet well

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.25%. Comparing base (aa89d27) to head (bbb938e).

Files with missing lines Patch % Lines
app/app.go 0.00% 25 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           asr/fee-validation-nonce    #3045      +/-   ##
============================================================
- Coverage                     58.26%   58.25%   -0.01%     
============================================================
  Files                          2072     2072              
  Lines                        171449   171470      +21     
============================================================
- Hits                          99899    99897       -2     
- Misses                        62638    62662      +24     
+ Partials                       8912     8911       -1     
Flag Coverage Δ
sei-chain-pr 47.93% <0.00%> (-0.31%) ⬇️
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 66.90% <0.00%> (-1.17%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arajasek arajasek force-pushed the asr/giga-misc-fixes branch from a57cdc2 to 29ab486 Compare March 11, 2026 13:55
@arajasek arajasek marked this pull request as ready for review March 12, 2026 13:27
@arajasek arajasek force-pushed the asr/giga-misc-fixes branch from 29ab486 to bbb938e Compare March 12, 2026 13:29
@arajasek arajasek changed the base branch from main to asr/fee-validation-nonce March 12, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant