feat(giga): more checks to match v2 correctness#3061
Closed
arajasek wants to merge 1 commit intoasr/giga-misc-fixesfrom
Closed
feat(giga): more checks to match v2 correctness#3061arajasek wants to merge 1 commit intoasr/giga-misc-fixesfrom
arajasek wants to merge 1 commit intoasr/giga-misc-fixesfrom
Conversation
Contributor
Author
|
Draft until confirmed working on pacific. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
stevenlanders
approved these changes
Mar 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## asr/giga-misc-fixes #3061 +/- ##
=======================================================
- Coverage 58.25% 58.23% -0.03%
=======================================================
Files 2072 2072
Lines 171470 171550 +80
=======================================================
- Hits 99897 99896 -1
- Misses 62662 62744 +82
+ Partials 8911 8910 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Subsumed by #3071 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This should be the last of the needed check to get correctness with v2. All of these are pretty unlikely to be hit (I assume mempool logic covers most of these things), but we should still have them in.
Testing performed to validate your change