Skip to content

feat(giga): more checks to match v2 correctness#3061

Closed
arajasek wants to merge 1 commit intoasr/giga-misc-fixesfrom
asr/more-giga-checks
Closed

feat(giga): more checks to match v2 correctness#3061
arajasek wants to merge 1 commit intoasr/giga-misc-fixesfrom
asr/more-giga-checks

Conversation

@arajasek
Copy link
Contributor

Describe your changes and provide context

This should be the last of the needed check to get correctness with v2. All of these are pretty unlikely to be hit (I assume mempool logic covers most of these things), but we should still have them in.

Testing performed to validate your change

@arajasek arajasek marked this pull request as draft March 12, 2026 17:12
@arajasek
Copy link
Contributor Author

Draft until confirmed working on pacific.

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 12, 2026, 5:13 PM

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.23%. Comparing base (bbb938e) to head (a5dfd66).

Files with missing lines Patch % Lines
app/app.go 0.00% 91 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           asr/giga-misc-fixes    #3061      +/-   ##
=======================================================
- Coverage                58.25%   58.23%   -0.03%     
=======================================================
  Files                     2072     2072              
  Lines                   171470   171550      +80     
=======================================================
- Hits                     99897    99896       -1     
- Misses                   62662    62744      +82     
+ Partials                  8911     8910       -1     
Flag Coverage Δ
sei-chain-pr 46.81% <0.00%> (-1.13%) ⬇️
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 63.21% <0.00%> (-3.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arajasek arajasek marked this pull request as ready for review March 13, 2026 13:21
@arajasek
Copy link
Contributor Author

Subsumed by #3071

@arajasek arajasek closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants